---

yaml --- r: 96060 b: refs/heads/master c: c800578 h: refs/heads/master v: v3
git-mirror · May 4, 2008 · fe319f2 · fe319f2
1 parent 8f292ff
commit fe319f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 3ba08b00e0d8413d79be9cab8ec085ceb6ae6fd6
+refs/heads/master: c8005785102e5b67ecf213f06a3d6c001f6f8cb4
diff --git a/trunk/net/core/skbuff.c b/trunk/net/core/skbuff.c
@@ -200,7 +200,9 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask,
 		goto nodata;
 
 	/*
-	 * See comment in sk_buff definition, just before the 'tail' member
+	 * Only clear those fields we need to clear, not those that we will
+	 * actually initialise below. Hence, don't put any more fields after
+	 * the tail pointer in struct sk_buff!
 	 */
 	memset(skb, 0, offsetof(struct sk_buff, tail));
 	skb->truesize = size + sizeof(struct sk_buff);