Skip to content

Commit

Permalink
W1: w1_family, remove unused variable need_exit
Browse files Browse the repository at this point in the history
Removed the w1_family structure member variable need_exit.  It was only
being set and never used.  Even if it were to be used it is a polling type
operation.

Signed-off-by: David Fries <david@fries.net>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
David Fries authored and Linus Torvalds committed Oct 16, 2008
1 parent 347ba8a commit fe3cb82
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
7 changes: 1 addition & 6 deletions drivers/w1/w1_family.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ int w1_register_family(struct w1_family *newf)

if (!ret) {
atomic_set(&newf->refcnt, 0);
newf->need_exit = 0;
list_add_tail(&newf->family_entry, &w1_families);
}
spin_unlock(&w1_flock);
Expand All @@ -73,9 +72,6 @@ void w1_unregister_family(struct w1_family *fent)
break;
}
}

fent->need_exit = 1;

spin_unlock(&w1_flock);

/* deatch devices using this family code */
Expand Down Expand Up @@ -113,8 +109,7 @@ struct w1_family * w1_family_registered(u8 fid)

static void __w1_family_put(struct w1_family *f)
{
if (atomic_dec_and_test(&f->refcnt))
f->need_exit = 1;
atomic_dec(&f->refcnt);
}

void w1_family_put(struct w1_family *f)
Expand Down
1 change: 0 additions & 1 deletion drivers/w1/w1_family.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ struct w1_family
struct w1_family_ops *fops;

atomic_t refcnt;
u8 need_exit;
};

extern spinlock_t w1_flock;
Expand Down

0 comments on commit fe3cb82

Please sign in to comment.