Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 322410
b: refs/heads/master
c: cee5848
h: refs/heads/master
v: v3
  • Loading branch information
John Stultz authored and Linus Torvalds committed Sep 1, 2012
1 parent 35f60de commit fe4cbc4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7a611e69b26069a511d9d5251c6a28af6c521121
refs/heads/master: cee58483cf56e0ba355fdd97ff5e8925329aa936
7 changes: 7 additions & 0 deletions trunk/include/linux/time.h
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ static inline bool timespec_valid(const struct timespec *ts)
/* Can't have more nanoseconds then a second */
if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC)
return false;
return true;
}

static inline bool timespec_valid_strict(const struct timespec *ts)
{
if (!timespec_valid(ts))
return false;
/* Disallow values that could overflow ktime_t */
if ((unsigned long long)ts->tv_sec >= KTIME_SEC_MAX)
return false;
Expand Down
10 changes: 5 additions & 5 deletions trunk/kernel/time/timekeeping.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ int do_settimeofday(const struct timespec *tv)
struct timespec ts_delta, xt;
unsigned long flags;

if (!timespec_valid(tv))
if (!timespec_valid_strict(tv))
return -EINVAL;

write_seqlock_irqsave(&tk->lock, flags);
Expand Down Expand Up @@ -476,7 +476,7 @@ int timekeeping_inject_offset(struct timespec *ts)

/* Make sure the proposed value is valid */
tmp = timespec_add(tk_xtime(tk), *ts);
if (!timespec_valid(&tmp)) {
if (!timespec_valid_strict(&tmp)) {
ret = -EINVAL;
goto error;
}
Expand Down Expand Up @@ -659,15 +659,15 @@ void __init timekeeping_init(void)
struct timespec now, boot, tmp;

read_persistent_clock(&now);
if (!timespec_valid(&now)) {
if (!timespec_valid_strict(&now)) {
pr_warn("WARNING: Persistent clock returned invalid value!\n"
" Check your CMOS/BIOS settings.\n");
now.tv_sec = 0;
now.tv_nsec = 0;
}

read_boot_clock(&boot);
if (!timespec_valid(&boot)) {
if (!timespec_valid_strict(&boot)) {
pr_warn("WARNING: Boot clock returned invalid value!\n"
" Check your CMOS/BIOS settings.\n");
boot.tv_sec = 0;
Expand Down Expand Up @@ -713,7 +713,7 @@ static struct timespec timekeeping_suspend_time;
static void __timekeeping_inject_sleeptime(struct timekeeper *tk,
struct timespec *delta)
{
if (!timespec_valid(delta)) {
if (!timespec_valid_strict(delta)) {
printk(KERN_WARNING "__timekeeping_inject_sleeptime: Invalid "
"sleep delta value!\n");
return;
Expand Down

0 comments on commit fe4cbc4

Please sign in to comment.