Skip to content

Commit

Permalink
atm: br2684: Do not move counters backwards
Browse files Browse the repository at this point in the history
This snippet has caused several bugs in the past, and I don't see the
point on substracting the skb len from netdev stats.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jorge Boncompte [DTI2] authored and David S. Miller committed Nov 22, 2011
1 parent e348c5e commit fe685b8
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions net/atm/br2684.c
Original file line number Diff line number Diff line change
Expand Up @@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
skb_queue_splice_init(rq, &queue);
spin_unlock_irqrestore(&rq->lock, flags);

skb_queue_walk_safe(&queue, skb, tmp) {
struct net_device *dev;

skb_queue_walk_safe(&queue, skb, tmp)
br2684_push(atmvcc, skb);
dev = skb->dev;

dev->stats.rx_bytes -= skb->len;
dev->stats.rx_packets--;
}

/* initialize netdev carrier state */
if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)
Expand Down

0 comments on commit fe685b8

Please sign in to comment.