Skip to content

Commit

Permalink
fec: call fec_restart() in fec_open()
Browse files Browse the repository at this point in the history
We called fec_stop() in fec_enet_close(), thus we have to call
fec_restart() in fec_enet_open().

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sascha Hauer authored and David S. Miller committed Apr 16, 2009
1 parent f0b3fbe commit fe957c4
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions drivers/net/fec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1489,6 +1489,8 @@ fec_enet_open(struct net_device *dev)
fep->sequence_done = 0;
fep->link = 0;

fec_restart(dev, 1);

if (fep->phy) {
mii_do_cmd(dev, fep->phy->ack_int);
mii_do_cmd(dev, fep->phy->config);
Expand All @@ -1505,18 +1507,14 @@ fec_enet_open(struct net_device *dev)
schedule();

mii_do_cmd(dev, fep->phy->startup);

/* Set the initial link state to true. A lot of hardware
* based on this device does not implement a PHY interrupt,
* so we are never notified of link change.
*/
fep->link = 1;
} else {
fep->link = 1; /* lets just try it and see */
/* no phy, go full duplex, it's most likely a hub chip */
fec_restart(dev, 1);
}

/* Set the initial link state to true. A lot of hardware
* based on this device does not implement a PHY interrupt,
* so we are never notified of link change.
*/
fep->link = 1;

netif_start_queue(dev);
fep->opened = 1;
return 0;
Expand Down

0 comments on commit fe957c4

Please sign in to comment.