Skip to content

Commit

Permalink
[PATCH] PNP: adjust pnp_register_card_driver() signature: es18xx
Browse files Browse the repository at this point in the history
Remove the assumption that pnp_register_card_driver() returns the
number of devices claimed.  And fix some __init/__devinit issues.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Acked-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Bjorn Helgaas authored and Linus Torvalds committed Mar 27, 2006
1 parent 6736a65 commit fea9739
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions sound/isa/es18xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2204,7 +2204,7 @@ static int __devinit snd_audiodrive_probe(struct snd_card *card, int dev)
return snd_card_register(card);
}

static int __init snd_es18xx_nonpnp_probe1(int dev, struct platform_device *devptr)
static int __devinit snd_es18xx_nonpnp_probe1(int dev, struct platform_device *devptr)
{
struct snd_card *card;
int err;
Expand All @@ -2221,7 +2221,7 @@ static int __init snd_es18xx_nonpnp_probe1(int dev, struct platform_device *devp
return 0;
}

static int __init snd_es18xx_nonpnp_probe(struct platform_device *pdev)
static int __devinit snd_es18xx_nonpnp_probe(struct platform_device *pdev)
{
int dev = pdev->id;
int err;
Expand Down Expand Up @@ -2297,6 +2297,8 @@ static struct platform_driver snd_es18xx_nonpnp_driver = {


#ifdef CONFIG_PNP
static unsigned int __devinitdata es18xx_pnp_devices;

static int __devinit snd_audiodrive_pnp_detect(struct pnp_card_link *pcard,
const struct pnp_card_device_id *pid)
{
Expand Down Expand Up @@ -2327,6 +2329,7 @@ static int __devinit snd_audiodrive_pnp_detect(struct pnp_card_link *pcard,

pnp_set_card_drvdata(pcard, card);
dev++;
es18xx_pnp_devices++;
return 0;
}

Expand Down Expand Up @@ -2397,10 +2400,10 @@ static int __init alsa_card_es18xx_init(void)
}

#ifdef CONFIG_PNP
i = pnp_register_card_driver(&es18xx_pnpc_driver);
if (i >= 0) {
err = pnp_register_card_driver(&es18xx_pnpc_driver);
if (!err) {
pnp_registered = 1;
cards += i;
cards += es18xx_pnp_devices;
}
#endif

Expand Down

0 comments on commit fea9739

Please sign in to comment.