Skip to content

Commit

Permalink
[SCSI] iscsi_tcp regression: remove bogus warn on in write path
Browse files Browse the repository at this point in the history
An empty r2tqueue is a valid state. It just means that we have
processed all that there was to do. This patch removes the WARN_ON
that was added when the kfifo changes were merged.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Mike Christie authored and James Bottomley committed Feb 17, 2010
1 parent b0483e7 commit fee099b
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/scsi/libiscsi_tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -992,12 +992,10 @@ static struct iscsi_r2t_info *iscsi_tcp_get_curr_r2t(struct iscsi_task *task)
if (r2t == NULL) {
if (kfifo_out(&tcp_task->r2tqueue,
(void *)&tcp_task->r2t, sizeof(void *)) !=
sizeof(void *)) {
WARN_ONCE(1, "unexpected fifo state");
sizeof(void *))
r2t = NULL;
}

r2t = tcp_task->r2t;
else
r2t = tcp_task->r2t;
}
spin_unlock_bh(&session->lock);
}
Expand Down

0 comments on commit fee099b

Please sign in to comment.