Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 108815
b: refs/heads/master
c: 1e0d5a5
h: refs/heads/master
i:
  108813: 70aa474
  108811: d6f4fda
  108807: 99f11bd
  108799: b3dd26f
v: v3
  • Loading branch information
David S. Miller committed Aug 18, 2008
1 parent ced195e commit fee289b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 20 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3a76e3716b4e571f5d91a20b6afb412560599083
refs/heads/master: 1e0d5a5747772182d1bb2525d8153da640fdfb58
1 change: 0 additions & 1 deletion trunk/include/net/sch_generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ struct Qdisc
struct gnet_stats_basic bstats;
struct gnet_stats_queue qstats;
struct gnet_stats_rate_est rate_est;
struct rcu_head q_rcu;
int (*reshape_fail)(struct sk_buff *skb,
struct Qdisc *q);

Expand Down
27 changes: 9 additions & 18 deletions trunk/net/sched/sch_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,14 +518,19 @@ void qdisc_reset(struct Qdisc *qdisc)
}
EXPORT_SYMBOL(qdisc_reset);

/* this is the rcu callback function to clean up a qdisc when there
* are no further references to it */
/* Under qdisc_lock(qdisc) and BH! */

static void __qdisc_destroy(struct rcu_head *head)
void qdisc_destroy(struct Qdisc *qdisc)
{
struct Qdisc *qdisc = container_of(head, struct Qdisc, q_rcu);
const struct Qdisc_ops *ops = qdisc->ops;

if (qdisc->flags & TCQ_F_BUILTIN ||
!atomic_dec_and_test(&qdisc->refcnt))
return;

if (qdisc->parent)
list_del(&qdisc->list);

#ifdef CONFIG_NET_SCHED
qdisc_put_stab(qdisc->stab);
#endif
Expand All @@ -542,20 +547,6 @@ static void __qdisc_destroy(struct rcu_head *head)

kfree((char *) qdisc - qdisc->padded);
}

/* Under qdisc_lock(qdisc) and BH! */

void qdisc_destroy(struct Qdisc *qdisc)
{
if (qdisc->flags & TCQ_F_BUILTIN ||
!atomic_dec_and_test(&qdisc->refcnt))
return;

if (qdisc->parent)
list_del(&qdisc->list);

call_rcu(&qdisc->q_rcu, __qdisc_destroy);
}
EXPORT_SYMBOL(qdisc_destroy);

static bool dev_all_qdisc_sleeping_noop(struct net_device *dev)
Expand Down

0 comments on commit fee289b

Please sign in to comment.