Skip to content

Commit

Permalink
OMAP2/3/4 clock: omap2_clk_prepare_for_reboot() is OMAP2xxx-only
Browse files Browse the repository at this point in the history
omap2_clk_prepare_for_reboot() is only applicable to OMAP2xxx chips,
so rename it to omap2xxx_clk_prepare_for_reboot() and only call it when
running on OMAP2xxx chips.  Remove the old stub in the OMAP3 clock code.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
  • Loading branch information
Paul Walmsley committed Jan 29, 2010
1 parent da4d290 commit feec127
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 29 deletions.
1 change: 0 additions & 1 deletion arch/arm/mach-omap2/clock.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ int omap2_clksel_set_parent(struct clk *clk, struct clk *new_parent);
u32 omap2_get_dpll_rate(struct clk *clk);
void omap2_init_dpll_parent(struct clk *clk);
int omap2_wait_clock_ready(void __iomem *reg, u32 cval, const char *name);
void omap2_clk_prepare_for_reboot(void);
int omap2_dflt_clk_enable(struct clk *clk);
void omap2_dflt_clk_disable(struct clk *clk);
void omap2_clk_dflt_find_companion(struct clk *clk, void __iomem **other_reg,
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/clock2xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const struct clkops clkops_omap2430_i2chs_wait = {
/*
* Set clocks for bypass mode for reboot to work.
*/
void omap2_clk_prepare_for_reboot(void)
void omap2xxx_clk_prepare_for_reboot(void)
{
u32 rate;

Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/clock2xxx.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ int omap2_reprogram_dpllcore(struct clk *clk, unsigned long rate);
unsigned long omap2xxx_clk_get_core_rate(struct clk *clk);
u32 omap2xxx_get_apll_clkin(void);
u32 omap2xxx_get_sysclkdiv(void);
void omap2xxx_clk_prepare_for_reboot(void);

/* REVISIT: These should be set dynamically for CONFIG_MULTI_OMAP2 */
#ifdef CONFIG_ARCH_OMAP2420
Expand Down
21 changes: 2 additions & 19 deletions arch/arm/mach-omap2/clock34xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,25 +150,6 @@ int omap3_dpll4_set_rate(struct clk *clk, unsigned long rate)
return omap3_noncore_dpll_set_rate(clk, rate);
}

/* Common clock code */

/*
* Set clocks for bypass mode for reboot to work.
*/
void omap2_clk_prepare_for_reboot(void)
{
/* REVISIT: Not ready for 343x */
#if 0
u32 rate;

if (vclk == NULL || sclk == NULL)
return;

rate = clk_get_rate(sclk);
clk_set_rate(vclk, rate);
#endif
}

void omap3_clk_lock_dpll5(void)
{
struct clk *dpll5_clk;
Expand All @@ -191,6 +172,8 @@ void omap3_clk_lock_dpll5(void)
return;
}

/* Common clock code */

/* REVISIT: Move this init stuff out into clock.c */

/*
Expand Down
5 changes: 0 additions & 5 deletions arch/arm/mach-omap2/clock44xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,3 @@ const struct clkops clkops_noncore_dpll_ops = {
.enable = &omap3_noncore_dpll_enable,
.disable = &omap3_noncore_dpll_disable,
};

void omap2_clk_prepare_for_reboot(void)
{
return;
}
8 changes: 5 additions & 3 deletions arch/arm/mach-omap2/prcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <plat/control.h>

#include "clock.h"
#include "clock2xxx.h"
#include "cm.h"
#include "prm.h"
#include "prm-regbits-24xx.h"
Expand Down Expand Up @@ -133,11 +134,12 @@ EXPORT_SYMBOL(omap_prcm_get_reset_sources);
void omap_prcm_arch_reset(char mode)
{
s16 prcm_offs;
omap2_clk_prepare_for_reboot();

if (cpu_is_omap24xx())
if (cpu_is_omap24xx()) {
omap2xxx_clk_prepare_for_reboot();

prcm_offs = WKUP_MOD;
else if (cpu_is_omap34xx()) {
} else if (cpu_is_omap34xx()) {
u32 l;

prcm_offs = OMAP3430_GR_MOD;
Expand Down

0 comments on commit feec127

Please sign in to comment.