Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 182230
b: refs/heads/master
c: 0f10dc8
h: refs/heads/master
v: v3
  • Loading branch information
Paul E. McKenney authored and Ingo Molnar committed Jan 13, 2010
1 parent b09f48d commit fef8c6a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: eb1ba45f1e7f6e626fefc063b340c7cbec9bd8c7
refs/heads/master: 0f10dc826646134dce3e5751512b87d30f3903e4
17 changes: 6 additions & 11 deletions trunk/kernel/rcutree.c
Original file line number Diff line number Diff line change
Expand Up @@ -1144,11 +1144,9 @@ void rcu_check_callbacks(int cpu, int user)
/*
* Scan the leaf rcu_node structures, processing dyntick state for any that
* have not yet encountered a quiescent state, using the function specified.
* Returns 1 if the current grace period ends while scanning (possibly
* because we made it end).
*/
static int rcu_process_dyntick(struct rcu_state *rsp,
int (*f)(struct rcu_data *))
static void rcu_process_dyntick(struct rcu_state *rsp,
int (*f)(struct rcu_data *))
{
unsigned long bit;
int cpu;
Expand All @@ -1161,7 +1159,7 @@ static int rcu_process_dyntick(struct rcu_state *rsp,
spin_lock_irqsave(&rnp->lock, flags);
if (rnp->completed != rsp->gpnum - 1) {
spin_unlock_irqrestore(&rnp->lock, flags);
return 1;
return;
}
if (rnp->qsmask == 0) {
spin_unlock_irqrestore(&rnp->lock, flags);
Expand All @@ -1181,7 +1179,6 @@ static int rcu_process_dyntick(struct rcu_state *rsp,
}
spin_unlock_irqrestore(&rnp->lock, flags);
}
return 0;
}

/*
Expand All @@ -1193,7 +1190,6 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed)
unsigned long flags;
struct rcu_node *rnp = rcu_get_root(rsp);
u8 forcenow;
u8 gpdone;

if (!rcu_gp_in_progress(rsp))
return; /* No grace period in progress, nothing to force. */
Expand Down Expand Up @@ -1226,10 +1222,9 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed)
break; /* So gcc recognizes the dead code. */

/* Record dyntick-idle state. */
gpdone = rcu_process_dyntick(rsp,
dyntick_save_progress_counter);
rcu_process_dyntick(rsp, dyntick_save_progress_counter);
spin_lock(&rnp->lock); /* irqs already disabled */
if (gpdone)
if (!rcu_gp_in_progress(rsp))
break;
/* fall into next case. */

Expand All @@ -1249,7 +1244,7 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed)

/* Check dyntick-idle state, send IPI to laggarts. */
spin_unlock(&rnp->lock); /* irqs remain disabled */
gpdone = rcu_process_dyntick(rsp, rcu_implicit_dynticks_qs);
rcu_process_dyntick(rsp, rcu_implicit_dynticks_qs);

/* Leave state in case more forcing is required. */

Expand Down

0 comments on commit fef8c6a

Please sign in to comment.