Skip to content

Commit

Permalink
[PATCH] Char: stallion, prints cleanup
Browse files Browse the repository at this point in the history
Too many information is printed out (they may be easily obtained through
sysfs), wipe them out in probe function.  Convert rest of them to dev_
variants.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Dec 8, 2006
1 parent b1b84fe commit fefaf9a
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions drivers/char/stallion.c
Original file line number Diff line number Diff line change
Expand Up @@ -2421,9 +2421,6 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
struct stlbrd *brdp;
unsigned int brdtype = ent->driver_data;

pr_debug("stl_initpcibrd(brdtype=%d,busnr=%x,devnr=%x)\n", brdtype,
pdev->bus->number, pdev->devfn);

if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE)
return -ENODEV;

Expand All @@ -2435,20 +2432,12 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
if ((brdp = stl_allocbrd()) == NULL)
return(-ENOMEM);
if ((brdp->brdnr = stl_getbrdnr()) < 0) {
printk("STALLION: too many boards found, "
dev_err(&pdev->dev, "too many boards found, "
"maximum supported %d\n", STL_MAXBRDS);
return(0);
}
brdp->brdtype = brdtype;

/*
* Different Stallion boards use the BAR registers in different ways,
* so set up io addresses based on board type.
*/
pr_debug("%s(%d): BAR[]=%Lx,%Lx,%Lx,%Lx IRQ=%x\n", __FILE__, __LINE__,
pci_resource_start(pdev, 0), pci_resource_start(pdev, 1),
pci_resource_start(pdev, 2), pci_resource_start(pdev, 3), pdev->irq);

/*
* We have all resources from the board, so let's setup the actual
* board structure now.
Expand All @@ -2467,7 +2456,7 @@ static int __devinit stl_pciprobe(struct pci_dev *pdev,
brdp->ioaddr2 = pci_resource_start(pdev, 1);
break;
default:
printk("STALLION: unknown PCI board type=%d\n", brdtype);
dev_err(&pdev->dev, "unknown PCI board type=%u\n", brdtype);
break;
}

Expand Down

0 comments on commit fefaf9a

Please sign in to comment.