Skip to content

Commit

Permalink
bq20z75: Add i2c retry mechanism
Browse files Browse the repository at this point in the history
With the support of platform data, now adding support for option i2c
retries on read/write failures. Ths is specified through the optional
platform data.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
  • Loading branch information
Rhyland Klein authored and Anton Vorontsov committed Mar 1, 2011
1 parent bb87910 commit ff28fce
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 6 deletions.
37 changes: 31 additions & 6 deletions drivers/power/bq20z75.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,30 +156,55 @@ struct bq20z75_info {

static int bq20z75_read_word_data(struct i2c_client *client, u8 address)
{
s32 ret;
struct bq20z75_info *bq20z75_device = i2c_get_clientdata(client);
s32 ret = 0;
int retries = 1;

if (bq20z75_device->pdata)
retries = max(bq20z75_device->pdata->i2c_retry_count + 1, 1);

while (retries > 0) {
ret = i2c_smbus_read_word_data(client, address);
if (ret >= 0)
break;
retries--;
}

ret = i2c_smbus_read_word_data(client, address);
if (ret < 0) {
dev_err(&client->dev,
dev_warn(&client->dev,
"%s: i2c read at address 0x%x failed\n",
__func__, address);
return ret;
}

return le16_to_cpu(ret);
}

static int bq20z75_write_word_data(struct i2c_client *client, u8 address,
u16 value)
{
s32 ret;
struct bq20z75_info *bq20z75_device = i2c_get_clientdata(client);
s32 ret = 0;
int retries = 1;

if (bq20z75_device->pdata)
retries = max(bq20z75_device->pdata->i2c_retry_count + 1, 1);

while (retries > 0) {
ret = i2c_smbus_write_word_data(client, address,
le16_to_cpu(value));
if (ret >= 0)
break;
retries--;
}

ret = i2c_smbus_write_word_data(client, address, le16_to_cpu(value));
if (ret < 0) {
dev_err(&client->dev,
dev_warn(&client->dev,
"%s: i2c write to address 0x%x failed\n",
__func__, address);
return ret;
}

return 0;
}

Expand Down
2 changes: 2 additions & 0 deletions include/linux/power/bq20z75.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
* struct bq20z75_platform_data - platform data for bq20z75 devices
* @battery_detect: GPIO which is used to detect battery presence
* @battery_detect_present: gpio state when battery is present (0 / 1)
* @i2c_retry_count: # of times to retry on i2c IO failure
*/
struct bq20z75_platform_data {
int battery_detect;
int battery_detect_present;
int i2c_retry_count;
};

#endif

0 comments on commit ff28fce

Please sign in to comment.