---

yaml
---
r: 174377
b: refs/heads/master
c: 6b17d90
h: refs/heads/master
i:
  174375: 76c6054
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 1032988c71f3f85483b2b4319684d1205a704c02
+refs/heads/master: 6b17d902fdd241adfa4ce780df20547b28bf5801

trunk/fs/ext4/fsync.c

@@ -60,7 +60,7 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync)
 
 	ret = flush_aio_dio_completed_IO(inode);
 	if (ret < 0)
-		goto out;
+		return ret;
 	/*
 	 * data=writeback:
 	 *  The caller's filemap_fdatawrite()/wait will sync the data.
@@ -79,10 +79,8 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync)
 	 *  (they were dirtied by commit).  But that's OK - the blocks are
 	 *  safe in-journal, which is all fsync() needs to ensure.
 	 */
-	if (ext4_should_journal_data(inode)) {
-		ret = ext4_force_commit(inode->i_sb);
-		goto out;
-	}
+	if (ext4_should_journal_data(inode))
+		return ext4_force_commit(inode->i_sb);
 
 	if (!journal)
 		ret = sync_mapping_buffers(inode->i_mapping);