Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 370973
b: refs/heads/master
c: f1f394b
h: refs/heads/master
i:
  370971: 98bac79
v: v3
  • Loading branch information
Rusty Russell committed Apr 22, 2013
1 parent 713cbea commit ff6023b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 17427e08faae3e63271a9c2d0edb6a22e5fbb54b
refs/heads/master: f1f394b1c33d93416c90f97e201d4d386c04af55
25 changes: 13 additions & 12 deletions trunk/drivers/lguest/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
#include "lg.h"

unsigned long switcher_addr;
struct page **lg_switcher_pages;
static struct vm_struct *switcher_vma;
static struct page **switcher_pages;

/* This One Big lock protects all inter-guest data structures. */
DEFINE_MUTEX(lguest_lock);
Expand Down Expand Up @@ -63,9 +63,10 @@ static __init int map_switcher(void)
* We allocate an array of struct page pointers. map_vm_area() wants
* this, rather than just an array of pages.
*/
switcher_pages = kmalloc(sizeof(switcher_pages[0])*TOTAL_SWITCHER_PAGES,
GFP_KERNEL);
if (!switcher_pages) {
lg_switcher_pages = kmalloc(sizeof(lg_switcher_pages[0])
* TOTAL_SWITCHER_PAGES,
GFP_KERNEL);
if (!lg_switcher_pages) {
err = -ENOMEM;
goto out;
}
Expand All @@ -75,8 +76,8 @@ static __init int map_switcher(void)
* so we make sure they're zeroed.
*/
for (i = 0; i < TOTAL_SWITCHER_PAGES; i++) {
switcher_pages[i] = alloc_page(GFP_KERNEL|__GFP_ZERO);
if (!switcher_pages[i]) {
lg_switcher_pages[i] = alloc_page(GFP_KERNEL|__GFP_ZERO);
if (!lg_switcher_pages[i]) {
err = -ENOMEM;
goto free_some_pages;
}
Expand Down Expand Up @@ -117,7 +118,7 @@ static __init int map_switcher(void)
* array of struct pages. It increments that pointer, but we don't
* care.
*/
pagep = switcher_pages;
pagep = lg_switcher_pages;
err = map_vm_area(switcher_vma, PAGE_KERNEL_EXEC, &pagep);
if (err) {
printk("lguest: map_vm_area failed: %i\n", err);
Expand All @@ -142,8 +143,8 @@ static __init int map_switcher(void)
i = TOTAL_SWITCHER_PAGES;
free_some_pages:
for (--i; i >= 0; i--)
__free_pages(switcher_pages[i], 0);
kfree(switcher_pages);
__free_pages(lg_switcher_pages[i], 0);
kfree(lg_switcher_pages);
out:
return err;
}
Expand All @@ -158,8 +159,8 @@ static void unmap_switcher(void)
vunmap(switcher_vma->addr);
/* Now we just need to free the pages we copied the switcher into */
for (i = 0; i < TOTAL_SWITCHER_PAGES; i++)
__free_pages(switcher_pages[i], 0);
kfree(switcher_pages);
__free_pages(lg_switcher_pages[i], 0);
kfree(lg_switcher_pages);
}

/*H:032
Expand Down Expand Up @@ -333,7 +334,7 @@ static int __init init(void)
goto out;

/* Now we set up the pagetable implementation for the Guests. */
err = init_pagetables(switcher_pages);
err = init_pagetables(lg_switcher_pages);
if (err)
goto unmap;

Expand Down
1 change: 1 addition & 0 deletions trunk/drivers/lguest/lg.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ bool lguest_address_ok(const struct lguest *lg,
unsigned long addr, unsigned long len);
void __lgread(struct lg_cpu *, void *, unsigned long, unsigned);
void __lgwrite(struct lg_cpu *, unsigned long, const void *, unsigned);
extern struct page **lg_switcher_pages;

/*H:035
* Using memory-copy operations like that is usually inconvient, so we
Expand Down

0 comments on commit ff6023b

Please sign in to comment.