Skip to content

Commit

Permalink
netpoll: Add netpoll_rx_processing
Browse files Browse the repository at this point in the history
Add a helper netpoll_rx_processing that reports when netpoll has
receive side processing to perform.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric W. Biederman authored and David S. Miller committed Mar 17, 2014
1 parent e97dc3f commit ff60763
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
18 changes: 14 additions & 4 deletions include/linux/netpoll.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,24 @@ static inline void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
local_irq_restore(flags);
}


#ifdef CONFIG_NETPOLL_TRAP
static inline bool netpoll_rx_processing(struct netpoll_info *npinfo)
{
return !list_empty(&npinfo->rx_np);
}
#else
static inline bool netpoll_rx_processing(struct netpoll_info *npinfo)
{
return false;
}
#endif

#ifdef CONFIG_NETPOLL
static inline bool netpoll_rx_on(struct sk_buff *skb)
{
struct netpoll_info *npinfo = rcu_dereference_bh(skb->dev->npinfo);

return npinfo && (!list_empty(&npinfo->rx_np) || npinfo->rx_flags);
return npinfo && (netpoll_rx_processing(npinfo) || npinfo->rx_flags);
}

static inline bool netpoll_rx(struct sk_buff *skb)
Expand All @@ -105,8 +115,8 @@ static inline bool netpoll_rx(struct sk_buff *skb)

npinfo = rcu_dereference_bh(skb->dev->npinfo);
spin_lock(&npinfo->rx_lock);
/* check rx_flags again with the lock held */
if (npinfo->rx_flags && __netpoll_rx(skb, npinfo))
/* check rx_processing again with the lock held */
if (netpoll_rx_processing(npinfo) && __netpoll_rx(skb, npinfo))
ret = true;
spin_unlock(&npinfo->rx_lock);

Expand Down
4 changes: 2 additions & 2 deletions net/core/netpoll.c
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ static void netpoll_neigh_reply(struct sk_buff *skb, struct netpoll_info *npinfo
int hlen, tlen;
int hits = 0, proto;

if (list_empty(&npinfo->rx_np))
if (!netpoll_rx_processing(npinfo))
return;

/* Before checking the packet, we do some early
Expand Down Expand Up @@ -770,7 +770,7 @@ int __netpoll_rx(struct sk_buff *skb, struct netpoll_info *npinfo)
struct netpoll *np, *tmp;
uint16_t source;

if (list_empty(&npinfo->rx_np))
if (!netpoll_rx_processing(npinfo))
goto out;

if (skb->dev->type != ARPHRD_ETHER)
Expand Down

0 comments on commit ff60763

Please sign in to comment.