fix leak in proc_set_super()

set_anon_super() can fail... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
git-mirror · Jun 12, 2011 · ff78fca · ff78fca
1 parent b99ca60
commit ff78fca
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/fs/proc/root.c b/fs/proc/root.c
@@ -28,11 +28,12 @@ static int proc_test_super(struct super_block *sb, void *data)
 
 static int proc_set_super(struct super_block *sb, void *data)
 {
-	struct pid_namespace *ns;
-
-	ns = (struct pid_namespace *)data;
-	sb->s_fs_info = get_pid_ns(ns);
-	return set_anon_super(sb, NULL);
+	int err = set_anon_super(sb, NULL);
+	if (!err) {
+		struct pid_namespace *ns = (struct pid_namespace *)data;
+		sb->s_fs_info = get_pid_ns(ns);
+	}
+	return err;
 }
 
 static struct dentry *proc_mount(struct file_system_type *fs_type,