Skip to content

Commit

Permalink
ARM: pxa: prevent PXA270 occasional reboot freezes
Browse files Browse the repository at this point in the history
Erratum 71 of PXA270M Processor Family Specification Update
(April 19, 2010) explains that watchdog reset time is just
8us insead of 10ms in EMTS.

If SDRAM is not reset, it causes memory bus congestion and
the device hangs. We put SDRAM in selfresh mode before watchdog
reset, removing potential freezes.

Without this patch PXA270-based ICP DAS LP-8x4x hangs after up to 40
reboots. With this patch it has successfully rebooted 500 times.

Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
Tested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Olof Johansson <olof@lixom.net>
  • Loading branch information
Sergei Ianovich authored and Olof Johansson committed Dec 12, 2013
1 parent 506cac1 commit ff88b47
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion arch/arm/mach-pxa/reset.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include <mach/regs-ost.h>
#include <mach/reset.h>
#include <mach/smemc.h>

unsigned int reset_status;
EXPORT_SYMBOL(reset_status);
Expand Down Expand Up @@ -81,6 +82,12 @@ static void do_hw_reset(void)
writel_relaxed(OSSR_M3, OSSR);
/* ... in 100 ms */
writel_relaxed(readl_relaxed(OSCR) + 368640, OSMR3);
/*
* SDRAM hangs on watchdog reset on Marvell PXA270 (erratum 71)
* we put SDRAM into self-refresh to prevent that
*/
while (1)
writel_relaxed(MDREFR_SLFRSH, MDREFR);
}

void pxa_restart(enum reboot_mode mode, const char *cmd)
Expand All @@ -104,4 +111,3 @@ void pxa_restart(enum reboot_mode mode, const char *cmd)
break;
}
}

0 comments on commit ff88b47

Please sign in to comment.