Skip to content

Commit

Permalink
ext4: remove redundant goto in ext4_ext_insert_extent()
Browse files Browse the repository at this point in the history
If eh->eh_entries is smaller than eh->eh_max, the routine will
go to the "repeat" and then go to "has_space" directlly ,
since argument "depth" and "eh" are not even changed.

Therefore, goto "has_space" directly and remove redundant "repeat" tag.

Signed-off-by: Robin Dong <sanbai@taobao.com>
  • Loading branch information
Robin Dong authored and Theodore Ts'o committed Jul 11, 2011
1 parent 2261228 commit ffb505f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/ext4/extents.c
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
goto merge;
}

repeat:
depth = ext_depth(inode);
eh = path[depth].p_hdr;
if (le16_to_cpu(eh->eh_entries) < le16_to_cpu(eh->eh_max))
Expand All @@ -1745,7 +1744,7 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
ext_debug("next leaf isn't full(%d)\n",
le16_to_cpu(eh->eh_entries));
path = npath;
goto repeat;
goto has_space;
}
ext_debug("next leaf has no free space(%d,%d)\n",
le16_to_cpu(eh->eh_entries), le16_to_cpu(eh->eh_max));
Expand Down

0 comments on commit ffb505f

Please sign in to comment.