Skip to content

Commit

Permalink
tracing: Remove redundant raw_init callbacks
Browse files Browse the repository at this point in the history
raw_init callback is optional.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4BFA37D4.7070500@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Li Zefan authored and Steven Rostedt committed Jun 28, 2010
1 parent c9d932c commit ffb9f99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
8 changes: 1 addition & 7 deletions kernel/trace/trace_export.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ ftrace_define_fields_##name(struct ftrace_event_call *event_call) \

#include "trace_entries.h"

static int ftrace_raw_init_event(struct ftrace_event_call *call)
{
INIT_LIST_HEAD(&call->class->fields);
return 0;
}

#undef __entry
#define __entry REC

Expand Down Expand Up @@ -158,7 +152,7 @@ static int ftrace_raw_init_event(struct ftrace_event_call *call)
struct ftrace_event_class event_class_ftrace_##call = { \
.system = __stringify(TRACE_SYSTEM), \
.define_fields = ftrace_define_fields_##call, \
.raw_init = ftrace_raw_init_event, \
.fields = LIST_HEAD_INIT(event_class_ftrace_##call.fields),\
}; \
\
struct ftrace_event_call __used \
Expand Down
10 changes: 1 addition & 9 deletions kernel/trace/trace_kprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1214,11 +1214,6 @@ static void probe_event_disable(struct ftrace_event_call *call)
}
}

static int probe_event_raw_init(struct ftrace_event_call *event_call)
{
return 0;
}

#undef DEFINE_FIELD
#define DEFINE_FIELD(type, item, name, is_signed) \
do { \
Expand Down Expand Up @@ -1486,15 +1481,12 @@ static int register_probe_event(struct trace_probe *tp)
int ret;

/* Initialize ftrace_event_call */
INIT_LIST_HEAD(&call->class->fields);
if (probe_is_return(tp)) {
INIT_LIST_HEAD(&call->class->fields);
call->event.funcs = &kretprobe_funcs;
call->class->raw_init = probe_event_raw_init;
call->class->define_fields = kretprobe_event_define_fields;
} else {
INIT_LIST_HEAD(&call->class->fields);
call->event.funcs = &kprobe_funcs;
call->class->raw_init = probe_event_raw_init;
call->class->define_fields = kprobe_event_define_fields;
}
if (set_print_fmt(tp) < 0)
Expand Down

0 comments on commit ffb9f99

Please sign in to comment.