Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 158389
b: refs/heads/master
c: c5cb183
h: refs/heads/master
i:
  158387: 235e059
v: v3
  • Loading branch information
Xiao Guangrong authored and Ingo Molnar committed Jul 10, 2009
1 parent e280e12 commit ffe7c20
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 34 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: ddc1637af217dbd8bc51f30e6d24e84476a869a6
refs/heads/master: c5cb183608167c744cb28bbd85884be5a4ce875d
39 changes: 6 additions & 33 deletions trunk/kernel/trace/trace_events_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -420,17 +420,7 @@ EXPORT_SYMBOL_GPL(init_preds);

static void filter_free_subsystem_preds(struct event_subsystem *system)
{
struct event_filter *filter = system->filter;
struct ftrace_event_call *call;
int i;

if (filter->n_preds) {
for (i = 0; i < filter->n_preds; i++)
filter_free_pred(filter->preds[i]);
kfree(filter->preds);
filter->preds = NULL;
filter->n_preds = 0;
}

list_for_each_entry(call, &ftrace_events, list) {
if (!call->define_fields)
Expand Down Expand Up @@ -607,26 +597,9 @@ static int filter_add_subsystem_pred(struct filter_parse_state *ps,
struct filter_pred *pred,
char *filter_string)
{
struct event_filter *filter = system->filter;
struct ftrace_event_call *call;
int err = 0;

if (!filter->preds) {
filter->preds = kzalloc(MAX_FILTER_PRED * sizeof(pred),
GFP_KERNEL);

if (!filter->preds)
return -ENOMEM;
}

if (filter->n_preds == MAX_FILTER_PRED) {
parse_error(ps, FILT_ERR_TOO_MANY_PREDS, 0);
return -ENOSPC;
}

filter->preds[filter->n_preds] = pred;
filter->n_preds++;

list_for_each_entry(call, &ftrace_events, list) {

if (!call->define_fields)
Expand Down Expand Up @@ -1029,12 +1002,12 @@ static int replace_preds(struct event_subsystem *system,

if (elt->op == OP_AND || elt->op == OP_OR) {
pred = create_logical_pred(elt->op);
if (call) {
if (call)
err = filter_add_pred(ps, call, pred);
filter_free_pred(pred);
} else
else
err = filter_add_subsystem_pred(ps, system,
pred, filter_string);
filter_free_pred(pred);
if (err)
return err;

Expand All @@ -1048,12 +1021,12 @@ static int replace_preds(struct event_subsystem *system,
}

pred = create_pred(elt->op, operand1, operand2);
if (call) {
if (call)
err = filter_add_pred(ps, call, pred);
filter_free_pred(pred);
} else
else
err = filter_add_subsystem_pred(ps, system, pred,
filter_string);
filter_free_pred(pred);
if (err)
return err;

Expand Down

0 comments on commit ffe7c20

Please sign in to comment.