Skip to content

Cluster #43

Merged
merged 9 commits into from Jan 9, 2019
Merged

Cluster #43

merged 9 commits into from Jan 9, 2019

Conversation

HendrikSchultheis
Copy link
Collaborator

Resolves #25

@HendrikSchultheis HendrikSchultheis changed the base branch from master to dev January 8, 2019 13:31
Copy link
Collaborator

@renewiegandt renewiegandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@renewiegandt renewiegandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. But looks good.

@@ -29,7 +29,8 @@ option_list <- list(
make_option(opt_str = c("--mismatch"), default = -2, help = "Mismatch score. Default = %default (CD-HIT parameter)", metavar = "integer"),
make_option(opt_str = c("--gap"), default = -6, help = "Gap score. Default = %default (CD-HIT parameter)", metavar = "integer"),
make_option(opt_str = c("--gap_ext"), default = -1, help = "Gap extension score. Default = %default (CD-HIT parameter)", metavar = "integer"),
make_option(opt_str = c("-x", "--sort_cluster_by_size"), default = 1, help = "Either sort cluster by decreasing length (= 0) or by decreasing size (= 1). Default = %default (CD-HIT parameter: -sc)", metavar = "integer")
make_option(opt_str = c("-x", "--sort_cluster_by_size"), default = 1, help = "Either sort cluster by decreasing length (= 0) or by decreasing size (= 1). Default = %default (CD-HIT parameter: -sc)", metavar = "integer"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between cluster length and cluster size?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decreasing length will sort after their sequences length whereas size sorts after number of members per cluster.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay.

@renewiegandt renewiegandt merged commit 9ab7116 into dev Jan 9, 2019
@HendrikSchultheis HendrikSchultheis mentioned this pull request Jan 10, 2019
35 tasks
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review cdhit_wrapper.R and reduce_sequence.R
2 participants