-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…print_extraction parses
…e and easy to understand
…masterJLU2018 into peak_calling merging peak calling
Thank you! The script is working. Please clean it up a little bit. Then it's ready to be merged. |
I noticed that your max pos column shows weird values:
|
the shown output is not from my script, as I don't write the column with the sequence |
Yeah i noticed it. Sorry, it was late at night :D |
…therwise it could be 0 as index
renewiegandt
requested changes
Jan 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to merge it to dev even if it may contain a bug. We need to get everything together to do a proper check.
But please remove the comments that contain code.
…roblems with start/end positions or max_pos, the footprint will not be written to the output file
renewiegandt
approved these changes
Jan 12, 2019
I would rename the parameter max_bp_between to max_gapor max_bp_gap |
… the sorting before check for merging
ok, I have changed the name of parameter from max_bp_between to min_gap |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the bug with merging of footprints, the code will soon be edited to look nice