Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
da262e7c39
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

wilson/cran-comments.md

Go to file
 
 
Cannot retrieve contributors at this time
Submission 1 Test environments R CMD check results Downstream dependencies Reviewer comments Submission 2 Test environments Submission comments R CMD check results Downstream dependencies
57 lines (41 sloc) 1.55 KB
Raw Blame

Submission 1

Test environments

  • local windows 7 install, R 3.5.1
  • debian 9.4, R 3.4.1
  • win-builder (devel and release)

R CMD check results

There were no ERRORs or WARNINGs.

There was 1 NOTE:

  • New submission

  • Possibly mis-spelled words in DESCRIPTION: Omics (3:30) omics (9:126)

    Both are spelled correctly. First is capital because of title case.

Downstream dependencies

I have also run R CMD check on downstream dependencies of wilson (https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). All packages that I could install passed.

Reviewer comments

Thanks, we see you have lots of cuntions without examples (which may be reasonable given they are not intended t be called by users directly). Nevertheless, it would be good to have them tested, so please create, if examples are not feasible, at least tests that execute the various functions in your package.

Best, Uwe Ligges

Submission 2

Test environments

  • local windows 7 install, R 3.5.1
  • debian 9.4, R 3.4.1
  • win-builder (devel and release)

Submission comments

Addressed reviewer comments by adding tests where possible.

R CMD check results

There were no ERRORs or WARNINGs.

There was 1 NOTE:

  • New submission

  • Possibly mis-spelled words in DESCRIPTION: Omics (3:30) omics (9:126)

    Both are spelled correctly. First is capital because of title case.

Downstream dependencies

I have also run R CMD check on downstream dependencies of wilson (https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). All packages that I could install passed.