This repository has been archived by the owner. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
8a92947
commit 61d86e8
Showing
1 changed file
with
9 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,57 +1,24 @@ | ||
# Submission 1 | ||
# Submission | ||
## Test environments | ||
* local windows 7 install, R 3.5.1 | ||
* debian 9.4, R 3.4.1 | ||
* win-builder (devel and release) | ||
|
||
## R CMD check results | ||
There were no ERRORs or WARNINGs. | ||
|
||
There was 1 NOTE: | ||
|
||
* New submission | ||
|
||
* Possibly mis-spelled words in DESCRIPTION: | ||
Omics (3:30) | ||
omics (9:126) | ||
|
||
Both are spelled correctly. First is capital because of title case. | ||
There were no NOTEs, ERRORs or WARNINGs. | ||
|
||
## Downstream dependencies | ||
I have also run R CMD check on downstream dependencies of wilson | ||
(https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). | ||
All packages that I could install passed. | ||
|
||
## Reviewer comments | ||
Thanks, we see you have lots of cuntions without examples (which may be reasonable given they are not intended t be called by users directly). | ||
Nevertheless, it would be good to have them tested, so please create, if examples are not feasible, at least tests that execute the various functions in your package. | ||
|
||
Best, | ||
Uwe Ligges | ||
## CRAN Message | ||
Dear maintainer of package wilson, | ||
|
||
# Submission 2 | ||
## Test environments | ||
* local windows 7 install, R 3.5.1 | ||
* debian 9.4, R 3.4.1 | ||
* win-builder (devel and release) | ||
please see <https://cran.r-project.org/web/checks/check_results_wilson.html> | ||
and find current problems with your package. | ||
|
||
## Submission comments | ||
Addressed reviewer comments by adding tests where possible. | ||
Please fix and resubmit before Sep 21 to safely retain the package on CRAN. | ||
|
||
## R CMD check results | ||
There were no ERRORs or WARNINGs. | ||
|
||
There was 1 NOTE: | ||
|
||
* New submission | ||
|
||
* Possibly mis-spelled words in DESCRIPTION: | ||
Omics (3:30) | ||
omics (9:126) | ||
|
||
Both are spelled correctly. First is capital because of title case. | ||
|
||
## Downstream dependencies | ||
I have also run R CMD check on downstream dependencies of wilson | ||
(https://github.molgen.mpg.de/loosolab/wilson/tree/master/revdep). | ||
All packages that I could install passed. | ||
Best wishes, | ||
Uwe Ligges |