Skip to content
This repository has been archived by the owner. It is now read-only.

I2dash #36

Merged
merged 15 commits into from Jul 26, 2019
Merged

I2dash #36

merged 15 commits into from Jul 26, 2019

Conversation

HendrikSchultheis
Copy link
Contributor

I implemented the heatmap, scatterplot and geneview to i2dash functions and included their respecting templates. The functions were tested by creating a document with i2dash.

@jenzopr Feel free to merge if everything is fine.

Copy link
Member

@jenzopr jenzopr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!
The linking is not yet fully implemented in the i2dash package. Can you remove the parameters related to linking (e.g. compID) from the function definition and set them to their non-linking defaults (compID <- NULL)?

DESCRIPTION Show resolved Hide resolved
@jenzopr
Copy link
Member

jenzopr commented Jul 26, 2019

Build will not succeed - the virtual machine is not functional currently 👎

@HendrikSchultheis
Copy link
Contributor Author

Should I completely remove the compId parameters or rather mark them as not implemented and not use it? Or in other words, will this functionality be implemented in the near future?

@jenzopr
Copy link
Member

jenzopr commented Jul 26, 2019

Hm, at first I thought it makes sense to just create a "non-functional" linking version, but probably the linking will get a major overhauling, so you can also remove anything related to linking. Thanks!

@jenzopr jenzopr merged commit e49957d into loosolab:master Jul 26, 2019
1 check was pending
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants