-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
… i2dash is installed
…d path to templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
The linking is not yet fully implemented in the i2dash
package. Can you remove the parameters related to linking (e.g. compID
) from the function definition and set them to their non-linking defaults (compID <- NULL
)?
Build will not succeed - the virtual machine is not functional currently 👎 |
Should I completely remove the compId parameters or rather mark them as not implemented and not use it? Or in other words, will this functionality be implemented in the near future? |
Hm, at first I thought it makes sense to just create a "non-functional" linking version, but probably the linking will get a major overhauling, so you can also remove anything related to linking. Thanks! |
I implemented the heatmap, scatterplot and geneview to i2dash functions and included their respecting templates. The functions were tested by creating a document with i2dash.
@jenzopr Feel free to merge if everything is fine.