AMDGPU spams log (regression in 5.15.128) #2979

pmenzel · 2023-09-12T10:26:21Z

Regression introduced in commit 4921792e04 (drm/amdgpu: install stub fence into potential unused fence pointers) in Linux 5.15.128:

commit 4921792e04f2125b5eadef9dbe9417a8354c7eff
Author: Lang Yu <Lang.Yu@amd.com>
Date:   Fri May 5 20:14:15 2023 +0800

    drm/amdgpu: install stub fence into potential unused fence pointers
    
    [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ]
    
    When using cpu to update page tables, vm update fences are unused.
    Install stub fence into these fence pointers instead of NULL
    to avoid NULL dereference when calling dma_fence_wait() on them.
    
    Suggested-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Lang Yu <Lang.Yu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>

 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Alex Deucher comments:

This was autoselected for stable, but was not applicable and should be reverted. I've asked Greg and Sasha to revert it.

Originally posted by @pmenzel in #2976 (comment)

The text was updated successfully, but these errors were encountered:

…inters" This reverts commit 4921792. [ 0.000000] Linux version 5.15.131.mx64.454 (root@theinternet.molgen.mpg.de) (gcc (GCC) 10.4.0, GNU ld (GNU Binutils) 2.41) #1 SMP Mon Sep 11 13:28:37 CEST 2023 [ 0.000000] Command line: BOOT_IMAGE=/boot/bzImage.x86_64 root=LABEL=root ro crashkernel=64G-:256M console=ttyS0,115200n8 console=tty0 init=/bin/systemd audit=0 random.trust_cpu=on systemd.unified_cgroup_hierarchy […] [ 0.000000] DMI: Dell Inc. Precision Tower 3620/0MWYPT, BIOS 2.24.0 11/10/2022 […] [ 38.107559] ------------[ cut here ]------------ [ 38.112197] WARNING: CPU: 2 PID: 550 at include/linux/dma-fence.h:478 amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.122494] Modules linked in: snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio led_class i915 8021q garp stp mrp llc amdgpu snd_hda_codec_hdmi snd_hda _intel tpm_tis snd_intel_dspcfg tpm_tis_core snd_hda_codec snd_hda_core snd_pcm tpm e1000e rng_core kvm iommu_v2 gpu_sched drm_ttm_helper iosf_mbi ttm irqbypass snd_timer snd soundcore wmi_bmof deflate efi_pstore iTCO_wdt intel_gtt iTCO_vendor_support wmi crc32c_intel video pstore nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc efivarfs ip_tables x_tables unix ipv6 autofs4 [ 38.174291] CPU: 2 PID: 550 Comm: Xorg:cs0 Not tainted 5.15.131.mx64.454 #1 [ 38.181251] Hardware name: Dell Inc. Precision Tower 3620/0MWYPT, BIOS 2.24.0 11/10/2022 [ 38.189348] RIP: 0010:amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.195310] Code: 39 48 85 db 74 19 48 8d 7b 38 b8 01 00 00 00 f0 0f c1 43 38 85 c0 74 41 78 14 83 c0 01 78 0f 48 89 5d 00 5b 5d c3 cc cc cc cc <0f> 0b eb bc be 01 00 00 00 e8 ec 95 fd e0 eb e5 be 03 00 00 00 e8 [ 38.214033] RSP: 0018:ffffc90001bcfb90 EFLAGS: 00010293 [ 38.219249] RAX: ffffffff82f430e0 RBX: ffff888109b04f40 RCX: 0000000000000059 [ 38.226369] RDX: ffff888103692598 RSI: ffff888109b04f40 RDI: ffff888131be98f8 [ 38.233488] RBP: ffff888131be98f8 R08: 0000000000000020 R09: 0000000000000001 [ 38.240608] R10: ffff88883dff9000 R11: 000000000002e158 R12: ffff888131be9878 [ 38.247737] R13: 0000000000000000 R14: 0000000000000000 R15: ffff888134d00000 [ 38.254858] FS: 00007f98ba42a6c0(0000) GS:ffff88881dc80000(0000) knlGS:0000000000000000 [ 38.262938] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 38.268688] CR2: 00000000007436f8 CR3: 0000000131b00004 CR4: 00000000003706e0 [ 38.275809] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 38.282930] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 38.290050] Call Trace: [ 38.292497] <TASK> [ 38.294594] ? __warn+0x80/0x100 [ 38.297820] ? amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.303197] ? report_bug+0x9e/0xc0 [ 38.306697] ? handle_bug+0x3c/0x70 [ 38.310181] ? exc_invalid_op+0x14/0x70 [ 38.314014] ? asm_exc_invalid_op+0x16/0x20 [ 38.318191] ? amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.323561] amdgpu_sync_vm_fence+0x1f/0x40 [amdgpu] [ 38.328603] amdgpu_cs_ioctl+0x15ae/0x1ec0 [amdgpu] [ 38.333569] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [ 38.339134] drm_ioctl_kernel+0xac/0x100 [ 38.343062] drm_ioctl+0x205/0x3b0 [ 38.346468] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [ 38.352043] amdgpu_drm_ioctl+0x49/0x80 [amdgpu] [ 38.356745] __x64_sys_ioctl+0x8b/0xb0 [ 38.360508] do_syscall_64+0x40/0x90 [ 38.364081] entry_SYSCALL_64_after_hwframe+0x62/0xcc [ 38.369128] RIP: 0033:0x7f98c4f1b4db [ 38.372709] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <41> 89 c0 3d 00 f0 ff ff 77 1b 48 8b 44 24 18 64 48 2b 04 25 28 00 [ 38.391439] RSP: 002b:00007f98ba4298e0 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 38.398997] RAX: ffffffffffffffda RBX: 00007f98ba4299a0 RCX: 00007f98c4f1b4db [ 38.406118] RDX: 00007f98ba4299a0 RSI: 00000000c0186444 RDI: 000000000000000f [ 38.413241] RBP: 00000000c0186444 R08: 00007f98ba429ae0 R09: 00007f98ba429a88 [ 38.420364] R10: 00000000007bb450 R11: 0000000000000246 R12: 0000000000000000 [ 38.427486] R13: 000000000000000f R14: 00000000fffffffd R15: 00000000007c87c8 [ 38.434610] </TASK> [ 38.436797] ---[ end trace ef9b2bf7b1907174 ]--- https://gitlab.freedesktop.org/drm/amd/-/issues/2820 Resolves: mariux64/bee-files#2979

pmenzel · 2023-09-12T11:09:24Z

6.1.52.mx64.456 and 6.5.2.mx64.452 are not affected by this.

Update the revision to 457. Resolves: #2979

…inters" This reverts commit 4921792. [ 0.000000] Linux version 5.15.131.mx64.454 (root@theinternet.molgen.mpg.de) (gcc (GCC) 10.4.0, GNU ld (GNU Binutils) 2.41) #1 SMP Mon Sep 11 13:28:37 CEST 2023 [ 0.000000] Command line: BOOT_IMAGE=/boot/bzImage.x86_64 root=LABEL=root ro crashkernel=64G-:256M console=ttyS0,115200n8 console=tty0 init=/bin/systemd audit=0 random.trust_cpu=on systemd.unified_cgroup_hierarchy […] [ 0.000000] DMI: Dell Inc. Precision Tower 3620/0MWYPT, BIOS 2.24.0 11/10/2022 […] [ 38.107559] ------------[ cut here ]------------ [ 38.112197] WARNING: CPU: 2 PID: 550 at include/linux/dma-fence.h:478 amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.122494] Modules linked in: snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio led_class i915 8021q garp stp mrp llc amdgpu snd_hda_codec_hdmi snd_hda _intel tpm_tis snd_intel_dspcfg tpm_tis_core snd_hda_codec snd_hda_core snd_pcm tpm e1000e rng_core kvm iommu_v2 gpu_sched drm_ttm_helper iosf_mbi ttm irqbypass snd_timer snd soundcore wmi_bmof deflate efi_pstore iTCO_wdt intel_gtt iTCO_vendor_support wmi crc32c_intel video pstore nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc efivarfs ip_tables x_tables unix ipv6 autofs4 [ 38.174291] CPU: 2 PID: 550 Comm: Xorg:cs0 Not tainted 5.15.131.mx64.454 #1 [ 38.181251] Hardware name: Dell Inc. Precision Tower 3620/0MWYPT, BIOS 2.24.0 11/10/2022 [ 38.189348] RIP: 0010:amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.195310] Code: 39 48 85 db 74 19 48 8d 7b 38 b8 01 00 00 00 f0 0f c1 43 38 85 c0 74 41 78 14 83 c0 01 78 0f 48 89 5d 00 5b 5d c3 cc cc cc cc <0f> 0b eb bc be 01 00 00 00 e8 ec 95 fd e0 eb e5 be 03 00 00 00 e8 [ 38.214033] RSP: 0018:ffffc90001bcfb90 EFLAGS: 00010293 [ 38.219249] RAX: ffffffff82f430e0 RBX: ffff888109b04f40 RCX: 0000000000000059 [ 38.226369] RDX: ffff888103692598 RSI: ffff888109b04f40 RDI: ffff888131be98f8 [ 38.233488] RBP: ffff888131be98f8 R08: 0000000000000020 R09: 0000000000000001 [ 38.240608] R10: ffff88883dff9000 R11: 000000000002e158 R12: ffff888131be9878 [ 38.247737] R13: 0000000000000000 R14: 0000000000000000 R15: ffff888134d00000 [ 38.254858] FS: 00007f98ba42a6c0(0000) GS:ffff88881dc80000(0000) knlGS:0000000000000000 [ 38.262938] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 38.268688] CR2: 00000000007436f8 CR3: 0000000131b00004 CR4: 00000000003706e0 [ 38.275809] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 38.282930] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 38.290050] Call Trace: [ 38.292497] <TASK> [ 38.294594] ? __warn+0x80/0x100 [ 38.297820] ? amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.303197] ? report_bug+0x9e/0xc0 [ 38.306697] ? handle_bug+0x3c/0x70 [ 38.310181] ? exc_invalid_op+0x14/0x70 [ 38.314014] ? asm_exc_invalid_op+0x16/0x20 [ 38.318191] ? amdgpu_sync_keep_later+0x76/0xc0 [amdgpu] [ 38.323561] amdgpu_sync_vm_fence+0x1f/0x40 [amdgpu] [ 38.328603] amdgpu_cs_ioctl+0x15ae/0x1ec0 [amdgpu] [ 38.333569] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [ 38.339134] drm_ioctl_kernel+0xac/0x100 [ 38.343062] drm_ioctl+0x205/0x3b0 [ 38.346468] ? amdgpu_cs_find_mapping+0x110/0x110 [amdgpu] [ 38.352043] amdgpu_drm_ioctl+0x49/0x80 [amdgpu] [ 38.356745] __x64_sys_ioctl+0x8b/0xb0 [ 38.360508] do_syscall_64+0x40/0x90 [ 38.364081] entry_SYSCALL_64_after_hwframe+0x62/0xcc [ 38.369128] RIP: 0033:0x7f98c4f1b4db [ 38.372709] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <41> 89 c0 3d 00 f0 ff ff 77 1b 48 8b 44 24 18 64 48 2b 04 25 28 00 [ 38.391439] RSP: 002b:00007f98ba4298e0 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 38.398997] RAX: ffffffffffffffda RBX: 00007f98ba4299a0 RCX: 00007f98c4f1b4db [ 38.406118] RDX: 00007f98ba4299a0 RSI: 00000000c0186444 RDI: 000000000000000f [ 38.413241] RBP: 00000000c0186444 R08: 00007f98ba429ae0 R09: 00007f98ba429a88 [ 38.420364] R10: 00000000007bb450 R11: 0000000000000246 R12: 0000000000000000 [ 38.427486] R13: 000000000000000f R14: 00000000fffffffd R15: 00000000007c87c8 [ 38.434610] </TASK> [ 38.436797] ---[ end trace ef9b2bf7b1907174 ]--- https://gitlab.freedesktop.org/drm/amd/-/issues/2820 Resolves: mariux64/bee-files#2979

pmenzel added a commit that referenced this issue Sep 12, 2023

linux-5.15.131: Revert commit to fix AMDGPU driver regression

18a6a9b

Update the revision to 457. Resolves: #2979

pmenzel mentioned this issue Sep 12, 2023

Linux 5.15.131: Revert amdgpu commit causing log spam #2982

Merged

pmenzel closed this as completed in #2982 Sep 12, 2023

AMDGPU spams log (regression in 5.15.128) #2979

AMDGPU spams log (regression in 5.15.128) #2979

pmenzel commented Sep 12, 2023

pmenzel commented Sep 12, 2023

AMDGPU spams log (regression in 5.15.128) #2979

AMDGPU spams log (regression in 5.15.128) #2979

Comments

pmenzel commented Sep 12, 2023

pmenzel commented Sep 12, 2023