Update wireshark #1015
Merged
Update wireshark #1015
+81
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two typos in the c-ares commit message.
|
pmenzel
approved these changes
Jan 31, 2019
c-ares is a C library for asynchronous DNS requests (including name resolves) [1]. Wireshark needs c-ares to enable external name resolution. Create bee file from standard template. [1] https://c-ares.haxx.se/
I want to rebuild wirekshark with c-ares to enable external name resolution. Update to latest and greatest stable version by the way.
Currently nobody is using lua scripts so the burden to track an external patch is not really justified. Remove lua patches for now.
donald
force-pushed
the
update-wireshark
branch
from
c57cfba
to
0724a52
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update wireshark to latest version and build with c-ares, so that external name resolution works:
And, btw. never ever run wireshark as root, as I did.