Build shared version of igraph library #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b1d6dd. Installing the Python package [python-igraph][1] importing it fails with the error below. $ pip install --user leidenalg DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. Collecting leidenalg Downloading https://files.pythonhosted.org/packages/b6/cc/d76baf78a3924ba6093a3ce8d14e2289f1d718bd3bcbb8252bb131d12daa/leidenalg-0.7.0.tar.gz (92kB) |████████████████████████████████| 102kB 3.3MB/s Collecting python-igraph>=0.7.1.0 (from leidenalg) Downloading https://files.pythonhosted.org/packages/0f/a0/4e7134f803737aa6eebb4e5250565ace0e2599659e22be7f7eba520ff017/python-igraph-0.7.1.post6.tar.gz (377kB) |████████████████████████████████| 378kB 7.5MB/s Building wheels for collected packages: leidenalg, python-igraph Building wheel for leidenalg (setup.py) ... done Stored in directory: /scratch/local/pmenzel/.cache/pip/wheels/29/55/48/5a04693a10f50297bcda23819ca23ab3470a61dd911851c8bd Building wheel for python-igraph (setup.py) ... done Stored in directory: /scratch/local/pmenzel/.cache/pip/wheels/41/d6/02/34eebae97e25f5b87d60f4c0687e00523e3f244fa41bc3f4a7 Successfully built leidenalg python-igraph Installing collected packages: python-igraph, leidenalg Successfully installed leidenalg-0.7.0 python-igraph-0.7.1.post6 pmenzel@godsavethequeen:~> python Python 2.7.16 (default, May 15 2019, 14:45:23) [GCC 7.3.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import igraph as ig Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/pmenzel/.local/lib/python2.7/site-packages/igraph/__init__.py", line 34, in <module> from igraph._igraph import * ImportError: /home/pmenzel/.local/lib/python2.7/site-packages/igraph/_igraph.so: undefined symbol: _ZTVN10__cxxabiv117__class_type_infoE Somehow it’s not linked against stdc++ correctly? [Missing stdc++ in during linking?*][2] might be a similar issue. Anyway, having the shared library for igraph around, python-igraph builds fine and can be imported too. So add it back again. [1]: https://github.com/igraph/python-igraph/ [2]: https://github.com/sensational/sassphp/issues/4
|
It makes no sense to have a so lying around that is used by a tobe build so (say py_igraph.so). If some upstream module can't link against a static library, then it's the error of the module and should be fixed accordingly. |
|
On 06/28/19 12:38, Thomas Kreitler wrote:
It makes no sense to have a so lying around that is used by a tobe
build so (say py_igraph.so). If some upstream module can't link
against a static library, then it's the error of the module and
should be fixed accordingly.
Yes, that’s the perfect world. But first our users probably do not
know how to do that, and just want to use the package, and secondly
I (and our group) do not have time for that either. Our to-do list
is too long already in my opinion.
|
|
Whats is a "tobe" build? |
|
a tobe build -- a build that might happen in some unforseable future. |
|
Wow, just noted that my mobe can't edit github comments. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on godsavethequeen with
pip install --user python-igraph(0.7.1.0) andimport igraphin Python.