Skip to content

dar: update from 2.4.11 to 2.6.5 #1242

Merged
merged 1 commit into from
Sep 5, 2019
Merged

dar: update from 2.4.11 to 2.6.5 #1242

merged 1 commit into from
Sep 5, 2019

Conversation

wwwutz
Copy link
Collaborator

@wwwutz wwwutz commented Sep 5, 2019

  • be0ify

@pmenzel
Copy link
Collaborator

pmenzel commented Sep 5, 2019

Do you know of any users? If not, shouldn’t it just be removed?

#}

mee_install_post() {
rm -vfr ${D}/usr/share/dar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREFIX should be used again instead of hard-coding paths, as bee allows to change the prefix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATADIR even.

$ bee --print-config
[…]
PREFIX=/usr
EPREFIX=${PREFIX}
BINDIR=${EPREFIX}/bin
SBINDIR=${EPREFIX}/sbin
LIBEXECDIR=${EPREFIX}/libexec
SYSCONFDIR=DEFAULT
LOCALSTATEDIR=DEFAULT
SHAREDSTATEDIR=${LOCALSTATEDIR}
LIBDIR=${EPREFIX}/lib
INCLUDEDIR=${PREFIX}/include
DATAROOTDIR=${PREFIX}/share
DATADIR=${DATAROOTDIR}
INFODIR=${DATAROOTDIR}/info
MANDIR=${DATAROOTDIR}/man
DOCDIR=${DATAROOTDIR}/doc/${PKGNAME}
LOCALEDIR=${DATAROOTDIR}/locale

mee_install_post() {
rm -vfr ${D}/usr/share/dar
rm -vfr ${D}/usr/include/dar
rm -vf ${D}/usr/lib/libdar64.a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBDIR for this..

rm -vfr ${D}/usr/include/dar
rm -vf ${D}/usr/lib/libdar64.a
rm -vf ${D}/usr/lib/pkgconfig/libdar64.pc
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your editor seems to strip proper line endings (or not add them).

rm -vfr ${D}/usr/share/dar
rm -vfr ${D}/usr/include/dar
rm -vf ${D}/usr/lib/libdar64.a
rm -vf ${D}/usr/lib/pkgconfig/libdar64.pc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the pkg-config file? Please add a comment.

@wwwutz
Copy link
Collaborator Author

wwwutz commented Sep 5, 2019

Instead of wasting your working time to correct 'style' and not 'content' of a program which was installed to be able to just extract .dar archives in a rare case of being confronted with one of them... so instead of wasting your and my time you might just pick ONE of the 279 outstanding bee files to fix and update.

Stop wasting my time commenting on bee-file-style which do not change the contents of the resulting package.

This is not contributing - this is annoying. Don't force me to put you on ignore.

CONTENT !

@wwwutz wwwutz merged commit 412ced4 into master Sep 5, 2019
@pmenzel
Copy link
Collaborator

pmenzel commented Sep 5, 2019

My Humblebee is very sad now. ;-)

$ ./humblebee.sh dar.be0
[…]
[BEE] -> saving bee-file dar.be0 ..
[BEE] /dev/shm/.local/src/bee/bee-files/dar-2.6.5-0.bee
'/home/pmenzel/bee-files/dar.be0' -> '/dev/shm/.local/src/bee/bee-files/dar-2.6.5-0.bee'
[BEE]  -> saving build environment..
[BEE] /dev/shm/.local/src/bee/build-archives/dar-2.6.5-0.x86_64.beebuild.tar.bz2

[BEE] ===================================================================
[BEE] build summary:
[BEE]
[BEE] download directory ${F}: /dev/shm/bee-build/dar/files
[BEE]   source directory ${S}: /dev/shm/bee-build/dar/dar-2.6.5-0/source
[BEE]    build directory ${B}: /dev/shm/bee-build/dar/dar-2.6.5-0/build
[BEE]    image directory ${D}: /dev/shm/bee-build/dar/dar-2.6.5-0/image
[BEE]
[BEE]      bee-file: /dev/shm/.local/src/bee/bee-files/dar-2.6.5-0.bee
[BEE]      pkg-file: /dev/shm/.local/src/bee/packages/dar-2.6.5-0.x86_64.bee.tar.bz2
[BEE] build-archive: /dev/shm/.local/src/bee/build-archives/dar-2.6.5-0.x86_64.beebuild.tar.bz2
[BEE] ===================================================================

tar: Removing leading `/' from member names
tar: Removing leading `/' from member names
Humblebee disapproves 176 != 21

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants