Skip to content

xpdf: update to 4.02 #1405

Merged
merged 5 commits into from Oct 24, 2019
Merged

xpdf: update to 4.02 #1405

merged 5 commits into from Oct 24, 2019

Conversation

wwwutz
Copy link
Collaborator

@wwwutz wwwutz commented Oct 21, 2019

  • new SRCURL
  • force QT5
  • add html & png
0 : /usr/share/bee/xpdf-3.04-0.x86_64/CONTENT
1 : /scratch/local/bee-root/xpdf/xpdf-4.02-0/image/CONTENT
 0 | 1 | t |  mode |  acc  | uid | gid | nln | file
 X | - | r |0100644|   0644|    0|    0|    1| /etc/xpdfrc
 - | X | r |0100755|   0755|    0|    0|    1| /usr/bin/xpdftohtml
 - | X | r |0100755|   0755|    0|    0|    1| /usr/bin/xpdftopng
 - | X | r |0100644|   0644|    0|    0|    1| /usr/share/man/man1/xpdftohtml.1
 - | X | r |0100644|   0644|    0|    0|    1| /usr/share/man/man1/xpdftopng.1

- new SRCURL
- force QT5
- add html & png
@thomas
Copy link
Collaborator

thomas commented Oct 21, 2019

Xpdf-4 has a little bug, that might yield to coredumps.
How to trigger:
a) open a pdf (what else ?)
b) [Window] -> 'open error window...' -> close with [X]
c) repeat b), the window has lost its content :(
d) quit app, the booboo might happen.

Options:

  • A quick fix would be to disable this item and recompile it.
  • Someone might look for the wrong free/delete (window destructor - guessed)
  • Proceed with fingers crossed

@thomas
Copy link
Collaborator

thomas commented Oct 21, 2019

Guess I've found the baddie, will check tomorrow.

@thomas
Copy link
Collaborator

thomas commented Oct 23, 2019

Hi Peter!

I have two great proposals for building this fine application (no, nothing wrong with me grin ...)

As for the cmake part, you may add the following:

-DA4_PAPER
-DRelWithDebInfo
-DCMAKE_COLOR_MAKEFILE=OFF
-DCMAKE_VERBOSE_MAKEFILE=ON

A4 is self explaining, the CMAKE ones show the reason for using RelWithDebInfo.

As for the misbehaving error window, the following sed command will pull it straight:
sed -i -e '/\slastSize = size();/ a \ hide();\n event->ignore();' ${S}/xpdf-qt/XpdfViewer.cc

Cheerio!

@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 23, 2019

Parse error in command line argument: -DA4_PAPER
Should be: VAR:type=value
CMake Error: No cmake script provided.
CMake Error: Problem processing arguments. Aborting.

@thomas
Copy link
Collaborator

thomas commented Oct 23, 2019

\

@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 23, 2019

hilft auch nicht:

root:invidia:/scratch/local/# \
> ^C

@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 23, 2019

zeig ma dein bee file

@thomas
Copy link
Collaborator

thomas commented Oct 23, 2019

hab keins :)

@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 23, 2019

OK, wieso soll ich also -DA4_PAPER reinpappen, wenn ich schon --enable-a4-paper drin habe ? Und wenn es einen Grund gibt, wo dann bitte ?

Selbiges gilt für -DRelWithDebInfo . Wo soll das hin in mein bee-file ?

@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 23, 2019

[BEE] cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=/usr/lib -DCMAKE_COLOR_MAKEFILE=OFF -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_PREFIX_PATH=/usr/local/qt5 --with-freetype2-includes=/usr/include/freetype2 --enable-opi --enable-multithreaded --enable-wordlist --enable-a4-paper -DRelWithDebInfo /scratch/local/bee-root/xpdf/xpdf-4.02-1/source
Parse error in command line argument: -DRelWithDebInfo
Should be: VAR:type=value
CMake Error: No cmake script provided.
CMake Error: Problem processing arguments. Aborting.

pmenzel and others added 4 commits October 23, 2019 13:09
>    -DMULTITHREADED=0
>        Disables multithreading, which also disables building the GUI
>        viewer (xpdf).  This does not affect the command line tools.
>        Disabling multithreading should only be necessary if you're
>        building with a compiler other than gcc, clang, or Microsoft
>        Visual Studio.

So it can be removed.
- new SRCURL
- force QT5
- add html & png
@wwwutz
Copy link
Collaborator Author

wwwutz commented Oct 24, 2019

Everything has been cleared so far. So go for it.

@wwwutz wwwutz merged commit 41284fb into master Oct 24, 2019
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants