Skip to content

Update graphviz 2.42.0 to 2.42.2 #1412

Merged
merged 8 commits into from Oct 24, 2019
Merged

Conversation

david
Copy link
Collaborator

@david david commented Oct 24, 2019

bring back .pc files

mee_patch() {
cd ${S}
start_cmd sed -i '/LIBPOSTFIX="64"/s/64//' configure.ac
./autogen.sh &> /dev/null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t bee run that automatically, if it detects a autogen.sh?

Prefix with start_cmd?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, bee dont do it

start_cmd dont work so I have removed it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, bee dont do it

For the future, use the BEE_BUILDTYPE=autogen, cf. https://github.com/bee/bee/blob/master/buildtypes/autogen.sh.in and /usr/libexec/bee/beesh.d/autogen.sh.

graphviz.be0 Outdated
###############################################################################
## Add filename patterns to the EXCLUDE array of files that should not
## be added to you package but may be present in the image directory.
# by cmd --version, you will get 2.43.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useful in the bee file? If yes, add it right under or above BEE_VERSION.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only a hint. I have moved it under BEE_VERSION


mee_configure() {
bee_configure -DCMAKE_COLOR_MAKEFILE=OFF -DCMAKE_VERBOSE_MAKEFILE=ON \
-DCMAKE_EXE_LINKER_FLAGS=-Wl,-rpath,/usr/lib/graphviz
bee_configure --disable-swig \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, if you also add the first switch on the next line, the indentation of all switches can be smaller.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I slipped

--without-x \
--without-glut \
--disable-perl \
--without-libgd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable so many features?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see commit a67e98a

graphviz.be0 Outdated
## by default this may be 'make install DESTDIR="${D}"'
mee_install() {
bee_install
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be commented out again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have forgotten this

## see http://beezinga.org/
##
mee_install_post(){
start_cmd rm -rf ${D}${DATAROOTDIR}/graphviz/doc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why they deviate from DOCDIR=${DATAROOTDIR}/doc/${PKGNAME}.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because they are special :-)

@pmenzel pmenzel merged commit 4661f8d into master Oct 24, 2019
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants