Bugfix update qt5 to 5.12.5 #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a subtle bug qt5-5.12.4 where window-close events aren't handled the default way.
Some digging into the topic showed that the addition of hide(); event->ignore(); simply enforces the default behaviour for a window close event. This seems to be special at least for Qt version 5.12.4, since it is neither needed for older Qt versions like 5.9, 5.10 nor for 5.12.5 . Note: This is not related to libev/libevent issues. The fault was present before libev was updated
|
Tested with some installed Qt5-apps, build against it, so it seems to be working. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple update to fix a minor bug was largely hampered by #1465.