Skip to content

cmake: disable unwanted /lib64 behaviour #1711

Merged
merged 1 commit into from Feb 24, 2020
Merged

cmake: disable unwanted /lib64 behaviour #1711

merged 1 commit into from Feb 24, 2020

Conversation

wwwutz
Copy link
Collaborator

@wwwutz wwwutz commented Feb 19, 2020

bee update cmake
  • change defaults not to search or link against /lib{32,64} by
    setting FIND_LIBRARY_USE_LIB{32,64}_PATH to FALSE
  • be verbose

Copy link
Collaborator

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem did you run into?

cmake.be0 Outdated
@@ -21,11 +22,12 @@ PATCHURL+=( /src/mariux/patches/cmake-3.16.2-color-off-verbose-on.patch )
#}

mee_configure() {
${S}/configure \
${S}/configure \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really... well... depends on... dunno... maybe ... for sure.

@pmenzel
Copy link
Collaborator

pmenzel commented Feb 19, 2020

Sorry, I mean, how can the problem be reproduced, that means, what program was built incorrectly.

@wwwutz
Copy link
Collaborator Author

wwwutz commented Feb 19, 2020

jasper-2.0.16. ( https://github.com/mdadams/jasper/archive/version-${PKGVERSION}.tar.gz" ) Thomas is currently working on it, so that's just an example. The resulting libs end in /usr/lib64.

Still debugging, since my patch didn't work.

@pmenzel
Copy link
Collaborator

pmenzel commented Feb 19, 2020

The bee build type CMake passes -DCMAKE_INSTALL_LIBDIR=${LIBDIR}, and manually building JasPer with cmake -DCMAKE_INSTALL_PREFIX=/dev/shm/bla -DCMAKE_INSTALL_LIBDIR=lib ../ works here.

@wwwutz
Copy link
Collaborator Author

wwwutz commented Feb 20, 2020

Been there, seen that. I'd prefer not to explicitly supply INSTALL_LIBDIR.
There is no /lib64 in our distro, and there should be none. So nothing should automagically decide to install something there.

- change defaults not to search or link against /lib{32,64} by
setting FIND_LIBRARY_USE_LIB{32,64}_PATH to FALSE
- remove lib64 default settings for GNUInstallDirs since they imply
 we would be running 32-Bit libs.
- be verbose
@wwwutz
Copy link
Collaborator Author

wwwutz commented Feb 21, 2020

< -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib64/libjasper.so.4.0.0
< -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib64/libjasper.so.4
< -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib64/libjasper.so
---
> -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib/libjasper.so.4.0.0
> -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib/libjasper.so.4
> -- Installing: /scratch/local/jasper/buildroot/jasper/jasper-2.0.16-0/image/usr/lib/libjasper.so

@wwwutz wwwutz merged commit 9d95251 into master Feb 24, 2020
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants