Skip to content

pyqt: Add PyQt for Qt4 and Qt5 #209

Merged
merged 2 commits into from
Nov 24, 2016
Merged

pyqt: Add PyQt for Qt4 and Qt5 #209

merged 2 commits into from
Nov 24, 2016

Conversation

thomas
Copy link
Collaborator

@thomas thomas commented Nov 22, 2016

PyQt is a set of Python v2 and v3 bindings for the Qt application
framework. Naming is a bit inconsistent:

  • PyQt-x11-gpl-4.11.4 -> Qt4
  • PyQt5_gpl-5.7 -> Qt5

Homepage:
https://www.riverbankcomputing.com/software/pyqt/intro

export QTDIR=/usr/local/qt4

## The source URL(s) array
SRCURL[0]="file:///src/mariux/beeroot/downloads/PyQt-x11-gpl-${PKGVERSION}.tar.gz"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t we download stuff from the Internet, and let Bee itself do the caching?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but Sourceforge-Urls suck.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root:afk:/usr/share/bee/# grep sourcef */*.be* | wc
    128     145   18424

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation: "we have 128 bees with sourceforge URLs, please use them". First question in case of debugging: WTF do these sources come from.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, convinced.

@pmenzel
Copy link
Collaborator

pmenzel commented Nov 22, 2016

Please prepend commands with start_cmd so that the log contains the executed commands.

@thomas
Copy link
Collaborator Author

thomas commented Nov 22, 2016

Don't know what you mean, is there some documentation?

@pmenzel
Copy link
Collaborator

pmenzel commented Nov 22, 2016

@thomas, documentation about start_cmd is unfortunately only in the Bee source code. Basically, right now without start_cmd the run command is not printed to the terminal (if I am not mistaken). With start_cmd it is (even in color).

@thomas
Copy link
Collaborator Author

thomas commented Nov 22, 2016

Which parts should be called with 'start_cmd', or will I find 'approved' examples in the repo?

@pmenzel
Copy link
Collaborator

pmenzel commented Nov 22, 2016

@thomas, I’d prepend the configure, make, and install lines, because then you also see the passed arguments.

@pmenzel
Copy link
Collaborator

pmenzel commented Nov 22, 2016

I forget, that one commit per program would be useful. These two commits are then grouped in a branch (merge/pull request).

@thomas
Copy link
Collaborator Author

thomas commented Nov 22, 2016

IIRC we have talked about having more than one bee file ina branch, which was ok. The granularity wasn't discussed. To achieve agreements about howto do 'this and that' via the git chat is way tedious. What about having a 'Best-Practices'-thingy somewhere written down?

@pmenzel
Copy link
Collaborator

pmenzel commented Nov 22, 2016

@thomas, my proposal is up for review since last week, cf. #204.

@thomas
Copy link
Collaborator Author

thomas commented Nov 22, 2016

I've took a quick look, seems like the thing I've meant. But without the hint I wouldn't have guessed that SubmittingPatches has something to do with creating bee files.

PyQt is a set of Python v2 and v3 bindings for the Qt application
framework. Naming is a bit inconsistent:
- PyQt-x11-gpl-4.11.4 -> Qt4
- PyQt5_gpl-5.7 -> Qt5

Homepage:
https://www.riverbankcomputing.com/software/pyqt/intro
PyQt is a set of Python v2 and v3 bindings for the Qt application
framework. Naming is a bit inconsistent:
- PyQt-x11-gpl-4.11.4 -> Qt4
- PyQt5_gpl-5.7 -> Qt5

Homepage:
https://www.riverbankcomputing.com/software/pyqt/intro
@donald
Copy link
Collaborator

donald commented Nov 24, 2016

I've split PyQt for Qt4 and PyQt for Qt5 into two separate commits, squashed the minor fixes ( add start_cmd and switch to sourceforge url ) and rebased on current master.

Tree is unchanged.

@donald donald merged commit f9defc1 into master Nov 24, 2016
@donald
Copy link
Collaborator

donald commented Nov 24, 2016

I'll install it on the distmaster

@donald donald deleted the add-PyQt branch November 24, 2016 09:23
@thomas
Copy link
Collaborator Author

thomas commented Nov 24, 2016

Merci

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants