lightdm: Add patch to avoid triggering home mounts. #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwutz
approved these changes
May 31, 2022
pmenzel
reviewed
May 31, 2022
|
Maybe AccountsService spend the time reading wtmp? |
|
I reported the issue upstream: https://github.com/canonical/lightdm/issues/254 |
As we have our homes on nfs, we don't want lightdm to search for icon files in the homes. Note, that the code, were lightdm enumerates the users and searches for icon files in the users homess, is not used in the normal case. It is only used when lightdm fails to get the service from accounts-service. We've had the situation on one system, were accounts-service failed to start in 30 seconds for unknown reassons after which gdm timed out and used its own code, thereby mounting all nfs homes. Because of the notify installed by the users filebrowser, these mounts even persisted. It is yet unclear, why accounts-service needed ca 32 sesconds to start. It was a special situation after a power failure on the campus which resulted in a disconnect network in that building. Anyway, if lightdm goes into the fallback mode for whatever reason, we don't want it to walk over all homes. Add patch.
Done |
We can wait with this one for an answer. |
pmenzel
requested changes
May 31, 2022
|
Hmmm. Github says "@pmenzel requested changes..." I resolved your review... |
pmenzel
approved these changes
May 31, 2022
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have our homes on nfs, we don't want lightdm to search for icon
files in the homes.
Note, that the code, were lightdm enumerates the users and searches for
icon files in the users homess, is not used in the normal case. It is
only used when lightdm fails to get the service from accounts-service.
We've had the situation on one system, were accounts-service failed to
start in 30 seconds for unknown reassons after which gdm timed out and
used its own code, thereby mounting all nfs homes. Because of the notify
installed by the users filebrowser, these mounts even persisted.
It is yet unclear, why accounts-service needed ca 32 sesconds to start.
It was a special situation after a power failure on the campus which
resulted in a disconnect network in that building.
Anyway, if lightdm goes into the fallback mode for whatever reason, we
don't want it to walk over all homes.
Add patch.