Switch iotop #2810
Merged
Switch iotop #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version and remove iotop
The Python-based iotop tool is no longer working on Mariux64 so add the C-based iotop standalone tool, which can made to work. A patch for Mariux64 is required, to let iotop work without CONFIG_TASK_DELAY_ACCT. Note, that this package is named iotop-c on some distributions
donald
added a commit
that referenced
this pull request
Jan 4, 2023
This kernel contains a patch, so that /proc/mounts and /proc/self/mountinfo format the nfs mariux security flavor as "sec=mariux" instead of "sec=unknown" [1] This kernel contains a patch to re-enable TASK_DELAY_ACCT [2]. The missing TASK_DELAY_ACCT is one reason, our old pyhton-based iotop stopped to work, and the new c-based iotop doesn't work in all modes. There is another reason, however, which is not yet understood. [3] [1]: mariux64/linux@f03653475294 [2]: mariux64/linux@2dbcbb0533d6 [3]: #2810
Merged
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickfix for Mariux64
In the Mariux 5.15.77-440 kernel, we don't have CONFIG_TASK_DELAY_ACCT. In older kernels, this was autoconfigured by CONFIG_KVM, but that was lost with commit 63b3f96e1a9 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT") which landed in v5.14.
However, even when we enable CONFIG_TASK_DELAY_ACCT and set the task_delayacct to sysctl 1, we still don't get any I/O output for the processes. The exact reason is not yet understood.
Replace iotop-python with iotop-c , which also doesn't work out of the box, but can be made to work by a patch.