xterm: Add minimumContrast menu toggle #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
412 is the newest release (2026-10-12). Drop `make install-ti` and the termcap/terminfo edits feeding it: run without DESTDIR, the terminfo never ended up in the package (the system xterm entries come from ncurses_terminfo_compat), and a non-root build writes to, or fails on, the host's terminfo directory. The package contains the same files as before, plus 16x16 pixmaps. Tested with `fakeroot beesh -c`, and under Xvfb: xterm starts with TERM=xterm, renders UTF-8, and sets erase to ^H, matching kbs in the system terminfo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apply xterm-412-min-contrast.patch and bump the revision to 412-1. The patch adds a minimumContrast resource and -mincontrast option. Text whose WCAG 2 contrast ratio against its background is below minimumContrast (default 3.0; 1 disables) is drawn lighter or darker, keeping its hue. Light gray on a light background or dark blue on black stays readable this way. The adjustment happens only when drawing, including the character under the cursor; stored colors, screen dumps and color reports are unchanged. It also avoids X server round-trips when converting pixels on TrueColor visuals with more than 8 significant bits per channel, for both the contrast filter and faint (SGR 2) colors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update xterm-412-min-contrast.patch and bump the revision to 412-2. The patch now also adds "Enable Minimum Contrast" to the VT Options menu, with the matching set-min-contrast(on/off/toggle) action, to turn the adjustment off and on at runtime. Enabling it when minimumContrast is 1 or less uses the default ratio, 3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Update xterm-412-min-contrast.patch and bump the revision to 412-3. Text whose color equaled its background was always left alone, as deliberate hiding. After the VT Options "Enable Reverse Video" toggle swaps palette colors 0/7 and 8/15, palette color 7 equals the default background, so such text stayed black on black. The patch now skips only text for which the application chose the same color index (or the same direct color) for both; concealed text is unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add xterm-412-embedded-font.patch with the font tarball as a second source, and bump the revision to 412-4. The patch compiles Cascadia Mono PL 2407.24 (regular and italic variable fonts, SIL OFL 1.1) into xterm and makes it the default faceName at 12 points. Unlike the previous bitmap default, Hack or DejaVu Sans Mono, it covers the braille patterns used by many TUIs, plus box drawing, block elements and Powerline symbols. The fonts are registered with fontconfig from memory at startup, so nothing is installed. faceName "" (-fa '') still selects bitmap fonts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the Cascadia Mono PL font source with hack-braille-3.003.tar.gz, update xterm-412-embedded-font.patch and bump the revision to 412-5. Hack Braille is Hack 3.003 with the braille patterns U+2800..U+28FF added, which Hack lacks and many TUIs use for graphs and spinners. The dots are drawn by a small fontTools script (in the tarball), using the geometry of the Nerd Fonts patcher's braille; no glyphs come from other fonts, so the license stays Hack's: MIT and the Bitstream Vera License, which requires the rename. All four styles are embedded and "Hack Braille" at 12 points is the default faceName. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bee keeps fetched files in a per-package cache by file name and reuses an existing file without checking the URL. Each update of xterm-412-min-contrast.patch and xterm-412-embedded-font.patch kept its name, so builds picked up stale copies: 412-2 and 412-4 were built with the first min-contrast patch (no menu toggle, no reverse video fix), and 412-5 failed because the Cascadia version of the font patch was applied to the Hack Braille sources. Give each patch a local file name that includes its md5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update xterm-412-min-contrast.patch and bump the revision to 412-2.
The patch now also adds "Enable Minimum Contrast" to the VT Options
menu, with the matching set-min-contrast(on/off/toggle) action, to turn
the adjustment off and on at runtime. Enabling it when minimumContrast
is 1 or less uses the default ratio, 3.0.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
xterm: Add minimumContrast patch
Apply xterm-412-min-contrast.patch and bump the revision to 412-1.
The patch adds a minimumContrast resource and -mincontrast option.
Text whose WCAG 2 contrast ratio against its background is below
minimumContrast (default 3.0; 1 disables) is drawn lighter or darker,
keeping its hue. Light gray on a light background or dark blue on black
stays readable this way. The adjustment happens only when drawing,
including the character under the cursor; stored colors, screen dumps
and color reports are unchanged.
It also avoids X server round-trips when converting pixels on TrueColor
visuals with more than 8 significant bits per channel, for both the
contrast filter and faint (SGR 2) colors.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
xterm: Update version from 303 to 412
412 is the newest release (2026-10-12).
Drop
make install-tiand the termcap/terminfo edits feeding it: runwithout DESTDIR, the terminfo never ended up in the package (the system
xterm entries come from ncurses_terminfo_compat), and a non-root build
writes to, or fails on, the host's terminfo directory.
The package contains the same files as before, plus 16x16 pixmaps.
Tested with
fakeroot beesh -c, and under Xvfb: xterm starts withTERM=xterm, renders UTF-8, and sets erase to ^H, matching kbs in the
system terminfo.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com