-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two typos in the commit message:
- When building or When (being) built
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- suggest
@@ -3,6 +3,7 @@ | |||
# BEE_VERSION OpenBLAS-0.2.19-0 | |||
|
|||
BEE_BUILDTYPE=make | |||
BEE_MAKEFLAGS="DYNAMIC_ARCH=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+=
to not override, what the user passes?
Rebuilt to /src/mariux, didn't change revision. |
I just noticed, the bee file name is not all lowercase. I’d prefer all lowercase. |
# BEE_VERSION OpenBLAS-0.2.19-0 | ||
|
||
BEE_BUILDTYPE=make | ||
BEE_MAKEFLAGS+="DYNAMIC_ARCH=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a space be prepended? Otherwise will cause an error.
BEE_MAKEFLAGS='-j' ./OpenBLAS.be0 -c
Lastly, do we need the static versions of the library? |
" do we need the static versions of the library? " |
When built with cmake it states CMake Warning at CMakeLists.txt:46 (message): CMake support is experimental. This will not produce the same Makefiles that OpenBLAS ships with. Only x86 support is currently available. Also the instructions at https://github.com/xianyi/OpenBLAS/wiki/Installation-Guide suggest to use plain make.
Quote https://github.com/xianyi/OpenBLAS/blob/develop/Makefile.rule: # If you want to support multiple architecture in one binary # DYNAMIC_ARCH = 1
Maybe we should have a BLAS library installed, seems to be very basic. See mails in helpdesk.