Add OpenBLAS #385
Merged
Add OpenBLAS #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenzel
reviewed
May 21, 2017
pmenzel
reviewed
May 21, 2017
| @@ -3,6 +3,7 @@ | |||
| # BEE_VERSION OpenBLAS-0.2.19-0 | |||
|
|
|||
| BEE_BUILDTYPE=make | |||
| BEE_MAKEFLAGS="DYNAMIC_ARCH=1" | |||
There was a problem hiding this comment.
+= to not override, what the user passes?
|
Rebuilt to /src/mariux, didn't change revision. |
|
I just noticed, the bee file name is not all lowercase. I’d prefer all lowercase. |
pmenzel
reviewed
May 31, 2017
| # BEE_VERSION OpenBLAS-0.2.19-0 | ||
|
|
||
| BEE_BUILDTYPE=make | ||
| BEE_MAKEFLAGS+="DYNAMIC_ARCH=1" |
There was a problem hiding this comment.
Should a space be prepended? Otherwise will cause an error.
BEE_MAKEFLAGS='-j' ./OpenBLAS.be0 -c
|
Lastly, do we need the static versions of the library? |
|
" do we need the static versions of the library? " |
When built with cmake it states
CMake Warning at CMakeLists.txt:46 (message):
CMake support is experimental. This will not produce the same Makefiles
that OpenBLAS ships with. Only x86 support is currently available.
Also the instructions at
https://github.com/xianyi/OpenBLAS/wiki/Installation-Guide
suggest to use plain make.
Quote https://github.com/xianyi/OpenBLAS/blob/develop/Makefile.rule: # If you want to support multiple architecture in one binary # DYNAMIC_ARCH = 1
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should have a BLAS library installed, seems to be very basic. See mails in helpdesk.