Skip to content

Rebuild accountsservice #558

Closed
wants to merge 4 commits into from
Closed

Rebuild accountsservice #558

wants to merge 4 commits into from

Conversation

donald
Copy link
Collaborator

@donald donald commented Dec 20, 2017

This is a mitigation to a yet unresolved nic problem with
OptiPlex 990 workstations. If we have a local passwd, the
accountsservice daemon will query shadow.byname over udp
for each account. Because of the network problem, we
sometimes loose packets and run into rpc timeouts, which are
not properly handled and prevent gdm to display the login
window.

Avoid this mess by disabling the loading of user information.
We don't need it, because we don't present a list of users to
pick from anyway.

@donald
Copy link
Collaborator Author

donald commented Dec 20, 2017

@anybody: Please test whether this works. I didn't, because I need to stay at home for some time today.

@david
Copy link
Collaborator

david commented Dec 20, 2017

tested on hmmjaaeh
and the gdm login screen came immediately

This is a mitigation to a yet unresolved nic problem with
OptiPlex 990 workstations. If we have a local passwd, the
accountsservice daemon will query shadow.byname over udp
for each account. Because of the network problem, we
sometimes loose packets and run into rpc timeouts, which are
not properly handled and prevent gdm to display the login
window.

Avoid this mess by disabling the loading of user information.
We don't need it, because we don't present a list of users to
pick from anyway.

--
@thomas
Copy link
Collaborator

thomas commented Dec 20, 2017

crispy patch :)

@pmenzel
Copy link
Collaborator

pmenzel commented Dec 20, 2017

Remember to update with sudo bee update -f accaccountsservice-0.6.13-1.

Also Rebuild accountsservice is not a very useful branch and merge/pull request name in my opinion. do-not-load-user-information or something similar is more useful.

@thomas
Copy link
Collaborator

thomas commented Dec 20, 2017

Yes and please dont change the branch name now, caus i'm getting tired of pressing the reload button every 2 minutes :)

@pmenzel
Copy link
Collaborator

pmenzel commented Dec 20, 2017

@thomas, as often I am having a hard time to understand what you want to say and what you are doing.

@pmenzel
Copy link
Collaborator

pmenzel commented Dec 20, 2017

Side note: Also I pushed the update to AccountsService 0.6.45 branch, but as systemd/libsystemd integration(?) had to be disabled due to our old systemd 27 version (systemd 18x required) no systemd service file is installed. I still need to clean that up.

@thomas
Copy link
Collaborator

thomas commented Dec 20, 2017

What I'm doing -- following the info and conversation on this topic ...
And when the comits are reorded while you are looking at one - github quarrels, and i need to reload the page, what is a bit annoying.

@thomas
Copy link
Collaborator

thomas commented Dec 20, 2017

ogunmakin:
gdm login screen comes subito...

@donald
Copy link
Collaborator Author

donald commented Dec 20, 2017

I'm not sure, whether we need more verbatim branch names. Its redundant information of what is in the commits. Plus the pull request title will go into the merge commit message (which could be better in this case). And, for example, if you put version numbers into the branch names, you need to rename the branches when version numbers change before the merge (as happened to add-linux-4.9.68 -> add-linux-4.9.70).

After the merge the branch should be deleted from github (I do that regularly) and I use git fetch --prune from time to time to clean up my local copy. So the name is volatile anyway. It will only persist in the merge commit message where you have the pull request tile.

That said, I'm going to rename the branch to "accountsservice-do-not-load-user-information" and update the tile, because I don't really care.

@donald donald closed this Dec 20, 2017
@donald donald deleted the rebuild-accountsservice branch December 20, 2017 09:29
@pmenzel
Copy link
Collaborator

pmenzel commented Dec 20, 2017 via email

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants