Add Linux 4.14.16 #596
Merged
Add Linux 4.14.16 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Announcements and change-logs are available online [1][2].
> commit 54e67ba7d20a5921cfe712cfe4bd773e75df10e0
> Author: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Date: Mon Jan 22 20:11:06 2018 +0000
>
> nfsd: auth: Fix gid sorting when rootsquash enabled
>
> commit 1995266727fa8143897e89b55f5d3c79aa828420 upstream.
>
> Commit bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility
> group_info allocators") appears to break nfsd rootsquash in a pretty
> major way.
>
> It adds a call to groups_sort() inside the loop that copies/squashes
> gids, which means the valid gids are sorted along with the following
> garbage. The net result is that the highest numbered valid gids are
> replaced with any lower-valued garbage gids, possibly including 0.
>
> We should sort only once, after filling in all the gids.
>
> Fixes: bdcf0a423ea1 ("kernel: make groups_sort calling a responsibility ...")
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Acked-by: J. Bruce Fields <bfields@redhat.com>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Wolfgang Walter <linux@stwm.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[1] https://lkml.org/lkml/2018/1/31/329
[2] https://cdn.kernel.org/pub/linux/kernel/v4.x/ChangeLog-4.14.16
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on keineahnung.