-
Notifications
You must be signed in to change notification settings - Fork 0
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c448ed
to
8858d33
Compare
Am 02.02.2018 um 10:43 schrieb Donald Buczek:
wait.. I amend
I guess you also mean the trailing whitespace. That would be nice.
|
8858d33
to
743cc16
Compare
There you are... |
pmenzel
reviewed
Feb 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some nits.
# out master branch of git@github.molgen.mpg.de:mariux64/bee-files.git | ||
# | ||
# git checkout master | ||
# git pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, git pull --rebase
is better for our workflow?
$pkg.='.noarch'; | ||
} else { | ||
$pkg.='.x86_64'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alignment is off. I suppose there is a Perl file linter somewhere?
my $beefile=$GIT_FILE{$pkg}; | ||
print "# package in git but not in system: $pkg ($beefile)\n"; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line at end.
This script can be used to compare the bee packages installed in the system with the bee files in the current working directory, which is assumend to be the checked out master branch of git@github.molgen.mpg.de:mariux64/bee-files.git git checkout master git pull scripts/check-installed
743cc16
to
878548a
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script can be used to compare the bee packages installed in the system with
the bee files in the current working directory, which is assumend to be the checked
out master branch of git@github.molgen.mpg.de:mariux64/bee-files.git