smartmontools: update from 6.0 to 6.6 #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaned up installation
pmenzel
reviewed
Feb 17, 2018
| mee_configure() { | ||
| bee_configure \ | ||
| --with-systemdsystemunitdir=no \ | ||
| --with-initscriptdir=no \ |
There was a problem hiding this comment.
git show highlights the inconsistent use of tabs and spaces in the two lines above.
pmenzel
reviewed
Feb 17, 2018
| mee_install() { | ||
| bee_install | ||
| exit | ||
| } |
There was a problem hiding this comment.
I wonder how this built. Doesn’t the exit drop you back into the bee shell? Even if not, the definition above should be removed.
There was a problem hiding this comment.
me two. The answer is, that there is another mee_install() without an exit following this one. well....
pmenzel
reviewed
Feb 17, 2018
| rm -rf ${D}/etc | ||
| rm -rf ${D}/usr/share/man/man5 | ||
| rm -f ${D}/usr/sbin/{smartd,update-smart-drivedb} | ||
| rm -f ${D}/usr/share/man/man8/{smartd,update-smart-drivedb}.8 |
There was a problem hiding this comment.
The commit message gives no reasoning/motivation, why we do not need these programs.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaned up installation