Update Qt WebKit from 5.9.0 to 5.212 #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If desired, adjust the build settings to avoid literally thousands of
unneeded warning messages:
sed -e '/CONFIG/a QMAKE_CXXFLAGS += -Wno-expansion-to-defined' \
-i Tools/qmake/mkspecs/features/unix/default_pre.prf
Qt WebKit 5.9.0 has problems with GCC 7.3.0, and [it’s recommended to use 5.212][1]. Update the build instructions according to the Wiki page [Building QtWebKit on Windows][2]. [1]: https://bugreports.qt.io/browse/QTBUG-61609?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&showAll=true [2]: https://github.com/annulen/webkit/wiki/Building-QtWebKit-on-Linux
The library is not installed in MarIuX, so disable it. ``` CMake Error at /usr/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message): Could NOT find Hyphen (missing: HYPHEN_INCLUDE_DIR HYPHEN_LIBRARIES) Call Stack (most recent call first): /usr/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE) Source/cmake/FindHyphen.cmake:37 (find_package_handle_standard_args) Source/cmake/OptionsQt.cmake:790 (find_package) Source/cmake/WebKitCommon.cmake:50 (include) CMakeLists.txt:137 (include) ```
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to Qt 5.10.1 the installed Qt WebKit 5.9.0, built against Qt 5.4.1, seems to have a problem. Several users report crashes of RStudio 1.1.383 and 1.1.444, the only/main user of Qt WebKit.
Rebuilding Qt WebKit fails due to problems with GCC 7.3.0. But, Qt WebKit 5.212 builds, and with that installed, RStudio doesn’t crash anymore.