Skip to content

Update Bison from 2.4.3 to 3.0.4 #73

Merged
merged 3 commits into from
Jul 29, 2016
Merged

Conversation

pmenzel
Copy link
Collaborator

@pmenzel pmenzel commented Jul 26, 2016

Edgar Steiger requested this for installing Clingo.

@thomas
Copy link
Collaborator

thomas commented Jul 27, 2016

Is there any reason for pull-requests on 'default' bee-files. I would commit them directly.
Or is it about the circumstance of updating bison?

@pmenzel
Copy link
Collaborator Author

pmenzel commented Jul 27, 2016

The policy is, that there are no direct commits to master. Changes get only in over merge/pull requests.

The reasons are, that

  1. Somebody sanity checks the changes
  2. Another person knows what’s going on regarding to be installed packages
  3. You learn from oneanother

@pmenzel
Copy link
Collaborator Author

pmenzel commented Jul 27, 2016

In this case you should wonder about the removal of echo '#define YYENABLE_NLS 1' >> lib/config.h and make check.

@pmenzel pmenzel force-pushed the update-bison-from-2.4.3-to-3.0.4 branch from 353e3e2 to 7604418 Compare July 27, 2016 08:26
@thomas
Copy link
Collaborator

thomas commented Jul 27, 2016

My resume would be: 'the new version builds w/o problems'.

@pmenzel
Copy link
Collaborator Author

pmenzel commented Jul 27, 2016

I updated the bee file to run make check in mee_build().

As the old bee file is not up to date, recreate the bee file with the
command below.

```
$ bee init https://ftp.gnu.org/gnu/bison/bison-3.0.4.tar.xz
creating bison-3.0.4-0.bee from template '/etc/default/bee/templates/fallback'
```

1.  Use the .xz archive, as no .bz2 archives are provided anymore.
2.  Keep running `make check` as in the old bee file.
3.  Do not set `#define YYENABLE_NLS 1` as it’s not clear, why it’s
    needed, and it’s not listed in the LFS book [1].

[1] http://www.linuxfromscratch.org/lfs/view/development/chapter06/bison.html
@pmenzel pmenzel force-pushed the update-bison-from-2.4.3-to-3.0.4 branch from 7604418 to b7d4ef3 Compare July 27, 2016 09:01
@pmenzel
Copy link
Collaborator Author

pmenzel commented Jul 27, 2016

I also updated SRCURL to be generic.

@thomas thomas merged commit 24760f8 into master Jul 29, 2016
@donald donald deleted the update-bison-from-2.4.3-to-3.0.4 branch August 21, 2016 09:58
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants