Skip to content

Update libidn #77

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Update libidn #77

merged 1 commit into from
Aug 1, 2016

Conversation

thomas
Copy link
Collaborator

@thomas thomas commented Aug 1, 2016

Funny, how did jemalloc get in?

@pmenzel
Copy link
Collaborator

pmenzel commented Aug 1, 2016

@thomas, it was probably still in your branch. How did you create the branch update-libidn?


# BEE_VERSION libidn-1.33-0

SRCURL[0]="http://ftp.gnu.org/gnu/libidn/libidn-${PKGVERSION}.tar.gz"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatfor ?
Anyway will test amending

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have a little bit more security, meaning, we at least know we connect to the GNU server.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested it with https?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not with this package, but with other GNU software. I can access https://ftp.gnu.org too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pmenzel
Copy link
Collaborator

pmenzel commented Aug 1, 2016

Could you please also delete the old libidn beefile?

@thomas
Copy link
Collaborator Author

thomas commented Aug 1, 2016

a) git branch update-libidn, status said 1 file
b) delete before install ?

@pmenzel
Copy link
Collaborator

pmenzel commented Aug 1, 2016

a) Well, the jemalloc commit was probably still in your branch you were in, when you executed git branch update-libidn.
b) I’d put it in the same (update) commit.

@pmenzel pmenzel closed this Aug 1, 2016
@pmenzel pmenzel reopened this Aug 1, 2016
@thomas
Copy link
Collaborator Author

thomas commented Aug 1, 2016

how could jemalloc be in the branch if i did a git checkout update-libidn and git status didn't tell anything about jemalloc?

@pmenzel
Copy link
Collaborator

pmenzel commented Aug 1, 2016

The jemalloc commit was already present in whatever branch you were. Then git show would show it, but not git status (only you are ahead …).

@thomas
Copy link
Collaborator Author

thomas commented Aug 1, 2016

I'll see if i can reproduce it.

@pmenzel pmenzel merged commit 9067e44 into master Aug 1, 2016
@pmenzel pmenzel deleted the update-libidn branch August 1, 2016 10:12
@thomas
Copy link
Collaborator Author

thomas commented Aug 1, 2016

nb. installation auf deinemuddah: morgen (2.8.2016)

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants