fftw: Update from 3.3.3 to 3.3.8 #877
Conversation
Rewrote the beefile to build all flavours of fftw. I'm aware that this bee file breaks with almost everything from the book 'good bee style'. If anyone has a better solution to consistently build fftw for various datatypes with bee -- let me know. Flames welcome :) https://www.youtube.com/watch?v=en1uwIzI3SE (Fire - The Crazy World Of Arthur Brown)
| $BUILD \ | ||
| $SIMD | ||
|
|
||
| make -j $(nproc) |
There was a problem hiding this comment.
Please use BEE_MAKEFLAGS.
There was a problem hiding this comment.
I think BEE_MAKEFLAGS should be only used from bees' make.
| ./configure \ | ||
| $DEFCONFIG \ | ||
| $BUILD \ | ||
| $SIMD |
There was a problem hiding this comment.
Add the above to mee_configure? Oh, you running it several times. Can it be factored out into it’s own function?
There was a problem hiding this comment.
All four configures are indeed slightly different, and to have a minimal function with 2 args wouldn't make it better to see the variation.
|
On 08/22/18 14:51, Thomas Kreitler wrote:
thomas commented on this pull request.
> + cd ${S}
+
+ # fix cflags
+ local MEE_CFLAGS="-O3 -fPIC"
+
+ sed -i "s|-mtune=native|$MEE_CFLAGS|" configure
+
+ SIMD='--enable-sse2 --enable-avx'
+ BUILD='--enable-threads --enable-openmp'
+
+ ./configure \
+ $DEFCONFIG \
+ $BUILD \
+ $SIMD
+
+ make -j $(nproc)
I think BEE_MAKEFLAGS should be only used from bees' make.
I don’t understand. `fftw.be0` *is* a *bee* file, and the user
shouldn’t have to read it before wanting to build something.
Let’s please stick to the standard, and use the environment
variable. Hardcoding it to the number of threads is not good™.
|
|
I have no deep objections in replacing the nproc with BEE_MAKEFLAGS, but from my point of view I'm putting the wool over the users eyes when I also 'emulate' BEE_MAKEFLAGS, or are BEE_MAKEFLAGS so strickly defined as 'passed exclusively to make', I'm not so sure. |
|
Since there have been no new arguments on the issue, and I wan't to proceed fixing other issues, I'll treat the above as a "the glas is half full", "no, it's half empty" discussion. |
|
On 08/22/18 15:13, Thomas Kreitler wrote:
I have no deep objections in replacing the nproc with BEE_MAKEFLAGS,
but from my point of view I'm putting the wool over the users eyes
when I also 'emulate' BEE_MAKEFLAGS, or are BEE_MAKEFLAGS so strickly
defined as 'passed exclusively to make', I'm not so sure.
```
$ git grep BEE_MAKEFLAGS
buildtypes/autogen.sh.in: start_cmd make ${BEE_MAKEFLAGS} "$@"
buildtypes/autogen.sh.in: start_cmd make ${BEE_MAKEFLAGS} install DESTDIR=${D} "$@"
buildtypes/autotools.sh.in: start_cmd make ${BEE_MAKEFLAGS} "$@"
buildtypes/autotools.sh.in: start_cmd make ${BEE_MAKEFLAGS} install DESTDIR=${D} "$@"
buildtypes/cmake.sh.in: start_cmd make ${BEE_MAKEFLAGS} "${@}"
buildtypes/cmake.sh.in: start_cmd make ${BEE_MAKEFLAGS} install DESTDIR=${D} "${@}"
buildtypes/make.sh.in: start_cmd make ${BEE_MAKEFLAGS} ${DEFCONFIG} "$@"
buildtypes/make.sh.in: start_cmd make ${BEE_MAKEFLAGS} install ${DEFCONFIG} DESTDIR=${D} "$@"
buildtypes/meson.sh.in: start_cmd ninja -v -C ${B} ${BEE_MAKEFLAGS} "${@}"
buildtypes/perl-module-makemaker.sh.in: start_cmd make ${BEE_MAKEFLAGS} \
buildtypes/perl-module-makemaker.sh.in: start_cmd make ${BEE_MAKEFLAGS} \
```
|
Rewrote the beefile to build all flavours of fftw.
I'm aware that this bee file breaks with almost everything
from the book 'good bee style'. If anyone has a better
solution to consistently build fftw for various datatypes
with bee -- let me know.
Flames welcome :)
https://www.youtube.com/watch?v=en1uwIzI3SE
(Fire - The Crazy World Of Arthur Brown)