Skip to content

julia: remove leftover RPATH from pcre shared libraries #92

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Commits on Aug 18, 2016

  1. julia: remove leftover RPATH from pcre shared libraries

    https://github.com/JuliaLang/julia/issues/18106
    
    Without this change the julia build system installed the
    two pcre shared libraries /usr/lib/julia/libpcre2-8.so.0.2.0
    and /usr/lib/julia/libpcre2-posix.so.0.0.0 with an RPATH
    to a build directory (eg.
    /dev/shm/bee-root/julia/julia-0.4.6-0/source/usr/lib) which is
    a security problem if the build directory is in a public
    writable temp space as is the case here.
    
    The patch
    
    --- a/deps/Makefile
    +++ b/deps/Makefile
    @@ -788,9 +788,6 @@ PCRE_OBJ_TARGET = $(build_shlibdir)/libpcre2-8.$(SHLIB_EXT)
    
     # Force optimization for PCRE flags (Issue #11668)
     PCRE_CFLAGS = -O3
    -ifneq ($(OS),WINNT)
    -PCRE_LDFLAGS = "-Wl,-rpath,'$(build_libdir)'"
    -endif
    
     pcre2-$(PCRE_VER).tar.bz2:
            $(JLDOWNLOAD) $@ https://ftp.csx.cam.ac.uk/pub/software/programming/pcre/pcre2-$(PCRE_VER).tar.bz2
    --
    
    fixed the problem only for one of the two libraries, as the RPATH of
    the other one is also set by the pcre build system.
    donald committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    afaf258 View commit details
    Browse the repository at this point in the history