Skip to content

time: Update from version 1.7 to 1.9 #985

Merged
merged 1 commit into from
Dec 24, 2018
Merged

time: Update from version 1.7 to 1.9 #985

merged 1 commit into from
Dec 24, 2018

Conversation

donald
Copy link
Collaborator

@donald donald commented Dec 24, 2018

Version 1.7 is outdated and incorrectly reports RSS scaled by factor 4:

$ curl -so mem.cpp https://ideone.com/plain/5bsp0R && make mem && /usr/bin/time -f "time thinks my peak rss is %M kB" ./mem
g++     mem.cpp   -o mem
procfs thinks my peak RSS is:       514652 kB
time thinks my peak rss is 2058608 kB

The problems was fixed for us by a patch in time-1.7-1 (commit 04c1410).

However, unlike assumed in the above commit, the bug is fixed in the
current release of time, which is 1.9. So instead of patching an obsolete
release, we should update to the current release.

$ /usr/bin/time --version
time (GNU Time) 1.9
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David Keppel, David MacKenzie, and Assaf Gordon.
$ curl -so mem.cpp https://ideone.com/plain/5bsp0R && make mem && /usr/bin/time -f "time thinks my peak rss is %M kB" ./mem
g++     mem.cpp   -o mem
procfs thinks my peak RSS is: 	  514564 kB
time thinks my peak rss is 514564 kB

Recreate bee file for version 1.9 from template.

Version 1.7 is outdated and incorrectly reports RSS scaled by factor 4:

    $ curl -so mem.cpp https://ideone.com/plain/5bsp0R && make mem && /usr/bin/time -f "time thinks my peak rss is %M kB" ./mem
    g++     mem.cpp   -o mem
    procfs thinks my peak RSS is:       514652 kB
    time thinks my peak rss is 2058608 kB

The problems was fixed for us by a patch in time-1.7-1 (bee-files/04c1410).

However, unlike assumed in the above commit, the bug is fixed in the
current release of time, which is 1.9. So instead of patching an obsolete
release, we should update to the current release.

    $ /usr/bin/time --version
    time (GNU Time) 1.9
    Copyright (C) 2018 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
    This is free software: you are free to change and redistribute it.
    There is NO WARRANTY, to the extent permitted by law.

    Written by David Keppel, David MacKenzie, and Assaf Gordon.
    $ curl -so mem.cpp https://ideone.com/plain/5bsp0R && make mem && /usr/bin/time -f "time thinks my peak rss is %M kB" ./mem
    g++     mem.cpp   -o mem
    procfs thinks my peak RSS is: 	  514564 kB
    time thinks my peak rss is 514564 kB

Recreate bee file for version 1.9 from template.
@pmenzel pmenzel merged commit 24ca603 into master Dec 24, 2018
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants