beesh: Add --fakeroot to fake root only for install and packaging
#76
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee-mxqsub runs all of beesh under fakeroot, so every process of the
configure and build steps inherits `LD_PRELOAD=libfakeroot.so`, and
their stat, chmod and chown calls are all served by the one faked
daemon. Large packages pay for this most: the Firefox build on a full
256-processor MXQ node was killed while packaging:
11:18.27 toolkit/library/build/libxul.so
13:21.72 ipc/app/plugin-container
14:38.60 E make[2]: *** Waiting for unfinished jobs....
/home/pmenzel/bee-files/scripts/bee-mxqsub: line 1: 222979 CPU time limit exceeded (core dumped) ${sandbox[@]+"${sandbox[@]}"} fakeroot beesh "${beesh_args[@]}" "${beefile}"
Without the preload, the same `mach build` took 11:34 instead of 17:37.
With the new option `--fakeroot`, beesh starts faked right before the
install step and stops it after packaging, so only install, crosscheck
and packaging see a fake root. bee-files had to work around this one by
one so far, like firefox.be0 with `env -u LD_PRELOAD`.
Starting faked late also keeps its database clean. If the build deletes
files outside of fakeroot, faked keeps their ownership records, and a
new file reusing the inode inherits the stale owner. In a test, 8 of
300 files copied with `cp -a` or `mv` into the image had the owner
recorded for deleted files. With faked started at the install step,
there are no such records.
beesh does not reimplement fakeroot’s setup: it runs `fakeroot` as a
coprocess, which reports FAKEROOTKEY, LD_PRELOAD and LD_LIBRARY_PATH,
and keeps faked alive until its standard input is closed, by
bee_fakeroot_stop() or by beesh exiting. Under fakeroot already, beesh
says so and keeps using the existing faked daemon.
The new help lines are indented with tabs like the rest of the `<<-EOF`
here-document, which strips only tabs, although `git diff --check`
warns about them:
src/beesh.sh.in:114: tab in indent.
Tested with a package whose Makefile installs with `-o root`, mode 4755
and `-o 1234`: the package built with `beesh --fakeroot` has the same
owners and modes as one built with `fakeroot beesh`, while the build
step ran with the real UID. A failing install leaves no faked behind.
Assisted-by: Claude Opus 5.5 (Claude Code) <noreply@anthropic.com>
Paul Menzel (pmenzel)
force-pushed
the
beesh-add-fakeroot-option
branch
from
46b5a78 to
06c57b2
Compare
Paul Menzel (pmenzel)
changed the title
--fakeroot to fake root only for install and packaging
Contributor
Author
Paul Menzel (pmenzel)
left a comment
Paul Menzel (pmenzel)
left a comment
There was a problem hiding this comment.
Read for review.
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
fakeroot bee …causes measurable overhead (Firefox: 11:34 instead of 17:37). Fake root only during install and packaging; configure and build run without faked’s overhead.