Bugfix for filenames with backslash and minor improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 1c04573 ("fn_escape: Do not use unicode regex") The commit missed the fact that not only non-graph characters but also the backslash character needs to be escaped. We run into errors when the original filename contains backslash characters like ./udev/links/\x2fdisk\x2fby-id\x2fscsi-35000c50084770037 which is wrongly decoded to ./udev/links//disk/by-id/scsi-35000c50084770037
Remove three void expressions which were used in early development to avoid "unused parameter" warnings when the code was incomplete.
We don't need g_spawn to close our file descriptiors. However, doing so produces unnecessary close() calls and interfers with debugging (e.g. valgrind).
The current option parsing code is based on g_option_context_parse from glib. This code doesn't support abbreviated long options. Additionally, there is a possible memory leak with the current implementation, because g_option_context_parse() removes processed options from the argument vector so these strings are not freed when argv runs out of scope. Switch to getopt_long. Because of the differences in the interfaces, we need to change the surrounding code a bit.
For some reason lost in ancient times, the slave is started with eitehr --delete or an explicit --nodelete. The later is not required, because that is the default.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.